From: Luiz Capitulino <lcapitulino@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Alon Levy <alevy@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach
Date: Wed, 20 Oct 2010 14:24:20 -0200 [thread overview]
Message-ID: <20101020142420.675fb9d3@doriath> (raw)
In-Reply-To: <4CBD9E85.50908@redhat.com>
On Tue, 19 Oct 2010 15:35:01 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:
> Hi,
>
> > + .help = "attach USB device 'bus.addr'",
>
> > +@item usb_attach @var{devname}
>
> /me sees a mismatch here.
>
> There is still the use case question. Also note that this might have
> unwanted side effects when drivers automagically attach/detach devices
> like usb-host.
Alon, did you check this? I hope it doesn't blowup.
> Having this purely for debugging/troubleshooting purposes would be fine
> with me, but the documentation should clearly say so.
Is this useful in production or only in the development of new devices? If
it's the letter, then I would even prefer enabling them only when DEBUG
is enabled.
next prev parent reply other threads:[~2010-10-20 16:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 10:33 [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v2) Alon Levy
2010-10-19 10:33 ` [Qemu-devel] [PATCH 1/3] qdev: make qdev_find_recursive public Alon Levy
2010-10-19 10:33 ` [Qemu-devel] [PATCH 2/3] usb: add public usb_device_by_id Alon Levy
2010-10-19 13:09 ` Gerd Hoffmann
2010-10-19 13:13 ` Alon Levy
2010-10-19 13:30 ` Gerd Hoffmann
2010-10-19 10:33 ` [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach Alon Levy
2010-10-19 13:35 ` Gerd Hoffmann
2010-10-20 16:24 ` Luiz Capitulino [this message]
2010-10-21 10:00 ` Gerd Hoffmann
2010-10-21 10:58 ` Alon Levy
2010-10-21 19:18 ` Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020142420.675fb9d3@doriath \
--to=lcapitulino@redhat.com \
--cc=alevy@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).