From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60573 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8nao-00072B-EI for qemu-devel@nongnu.org; Thu, 21 Oct 2010 01:21:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8nan-0005XU-7w for qemu-devel@nongnu.org; Thu, 21 Oct 2010 01:21:34 -0400 Received: from verein.lst.de ([213.95.11.210]:39663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8nam-0005XP-TP for qemu-devel@nongnu.org; Thu, 21 Oct 2010 01:21:33 -0400 Date: Thu, 21 Oct 2010 07:21:32 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH 2/2] ide: Handle flush failure Message-ID: <20101021052132.GC15430@lst.de> References: <1287500932-7366-1-git-send-email-kwolf@redhat.com> <1287500932-7366-3-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1287500932-7366-3-git-send-email-kwolf@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Tue, Oct 19, 2010 at 05:08:52PM +0200, Kevin Wolf wrote: > Instead of always assuming success for bdrv_aio_flush, actually do something > with the error. This respects the werror option and accordingly ignores the > error, reports it to the guest or stops the VM and retries after cont. > > Ignoring the error is trivial, obviously. For stopping the VM and retrying > later old code can be reused, but we need to introduce a new status for "retry > a flush". For reporting to the guest, fortunately the same action is required > as for a failed read/write (status = DRDY | ERR, error = ABRT), so this code > can be reused as well. ACK