From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38252 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8v86-0002fw-PB for qemu-devel@nongnu.org; Thu, 21 Oct 2010 09:24:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8v85-0005Us-My for qemu-devel@nongnu.org; Thu, 21 Oct 2010 09:24:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8v85-0005Uk-Ak for qemu-devel@nongnu.org; Thu, 21 Oct 2010 09:24:25 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9LDOMUN002164 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 21 Oct 2010 09:24:23 -0400 Received: from playa.tlv.redhat.com (dhcp-2-227.tlv.redhat.com [10.35.2.227]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o9LDOIL3001346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Thu, 21 Oct 2010 09:24:21 -0400 Date: Thu, 21 Oct 2010 15:24:18 +0200 From: Alon Levy Subject: Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3) Message-ID: <20101021132418.GD22958@playa.tlv.redhat.com> References: <1287642991-21114-1-git-send-email-alevy@redhat.com> <4CC03A2D.9030105@redhat.com> <4CC03C6F.4020304@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CC03C6F.4020304@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: > On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: > >On 10/21/10 08:36, Alon Levy wrote: > >>v2->v3 changes: > >> * add configure parameter > >> * fix docs > >> > >>v2 message: > >>This patchset uses id like device_del for attaching/detaching usb > >>devices. The first two patches ready the way: > >> 1. makes qdev_find_recursive non static and in qdev.h > >> 2. adds a usb_device_by_id which goes over the usb buses calling > >> qdev_find_recursive > >> 3. adds the commands that use usb_device_by_id > >> > >>Alon Levy (3): > >> qdev: make qdev_find_recursive public > >> usb: add public usb_device_by_id > >> monitor: add usb_attach and usb_detach (v2) > >> > > > >Acked-by: Gerd Hoffmann > > Okay, I am still confused about the use-case for this and I don't > see any further explanation in the commit messages. I've seen > "debugging" but can you be a bit more specific about which cases > it's needed for? > I use it for debugging the usb-ccid device. I think it's useful for any other usb device tests as well. The existing commands are not good enough to do a remove/insert of a usb device, since deleting a device also deletes any chardev associated with it, and there is no monitor command to add a chardev. Also sometimes you don't want to close the chardev, just have the guest see a removal/reinsert of the device. > This is just adding a HMP command. Is that the right approach or > was that an unintentional consequence of rebasing post-HMP/QMP > split? > yes, my bad, I have not used qmp before, I can add the code but no idea how to test it easily. > Regards, > > Anthony Liguori > > > > >cheers, > > Gerd > > > > > >