From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40259 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P8vBD-0004GH-D6
	for qemu-devel@nongnu.org; Thu, 21 Oct 2010 09:27:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1P8vB5-0006NG-9x
	for qemu-devel@nongnu.org; Thu, 21 Oct 2010 09:27:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56001)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1P8vB5-0006Mv-3n
	for qemu-devel@nongnu.org; Thu, 21 Oct 2010 09:27:31 -0400
Date: Thu, 21 Oct 2010 15:27:23 +0200
From: Alon Levy <alevy@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)
Message-ID: <20101021132723.GE22958@playa.tlv.redhat.com>
References: <1287642991-21114-1-git-send-email-alevy@redhat.com>
	<4CC03A2D.9030105@redhat.com> <4CC03C6F.4020304@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CC03C6F.4020304@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote:
> On 10/21/2010 08:03 AM, Gerd Hoffmann wrote:
> >On 10/21/10 08:36, Alon Levy wrote:
> >>v2->v3 changes:
> >>  * add configure parameter
> >>  * fix docs
> >>
> >>v2 message:
> >>This patchset uses id like device_del for attaching/detaching usb
> >>devices. The first two patches ready the way:
> >>  1. makes qdev_find_recursive non static and in qdev.h
> >>  2. adds a usb_device_by_id which goes over the usb buses calling
> >>   qdev_find_recursive
> >>  3. adds the commands that use usb_device_by_id
> >>
> >>Alon Levy (3):
> >>   qdev: make qdev_find_recursive public
> >>   usb: add public usb_device_by_id
> >>   monitor: add usb_attach and usb_detach (v2)
> >>
> >
> >Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> Okay, I am still confused about the use-case for this and I don't
> see any further explanation in the commit messages.  I've seen
> "debugging" but can you be a bit more specific about which cases
> it's needed for?

To elaborate a little more, when using a certificates based card
there is no hardware event (i.e. removing/inserting the physical card)
that causes a usb_detach/attach to the card (both in passthru and
emulated), but otoh certificates is good for testing since it decouples
it from NSS/tcp. So I needed some way to emulate an insert/remove, and
I saw usb_del, which was pretty close, and voila. This is not the same
as card remove/reinsert, but it is exactly what will happen to the
guest when spicec connects/disconnects, since I detach devices on
disconnect and attach on connect.

> 
> This is just adding a HMP command.  Is that the right approach or
> was that an unintentional consequence of rebasing post-HMP/QMP
> split?
> 
> Regards,
> 
> Anthony Liguori
> 
> >
> >cheers,
> >  Gerd
> >
> >
> 
>