From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44062 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P9Hw8-0003WM-MT
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 09:45:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1P9Hw6-0003dy-K6
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 09:45:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9543)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1P9Hw6-0003ds-AA
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 09:45:34 -0400
Date: Fri, 22 Oct 2010 11:45:29 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)
Message-ID: <20101022114529.66fe689d@doriath>
In-Reply-To: <4CC1950B.5020805@codemonkey.ws>
References: <1287642991-21114-1-git-send-email-alevy@redhat.com>
	<4CC03A2D.9030105@redhat.com> <4CC03C6F.4020304@codemonkey.ws>
	<20101021132723.GE22958@playa.tlv.redhat.com>
	<20101022104822.5f608f13@doriath> <4CC189A6.30807@codemonkey.ws>
	<20101022111744.69c4be17@doriath> <4CC1950B.5020805@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Alon Levy <alevy@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On Fri, 22 Oct 2010 08:43:39 -0500
Anthony Liguori <anthony@codemonkey.ws> wrote:

> On 10/22/2010 08:17 AM, Luiz Capitulino wrote:
> > You and Gerd asked about the purpose of this command, turns out that it's
> > only useful for developing new USB devices for QEMU, so I thought it would
> > be better to restrict it, so that people don't start using this the
> > wrong way or worse, we can't drop/break it because some tool is now using it.
> >    
> 
> Need HMP commands have no support associated with them.  Given QMP, 
> there's no reason to script HMP commands.
> 
> But a long standing policy in QEMU has been to avoid conditional code 
> because it results in dead code.  I think this policy has actually 
> worked well for us historically.

Fine with me.