From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34890 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P9K4z-0006Uv-Ut
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 12:02:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1P9JsR-0003D6-FG
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 11:49:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51161)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1P9JsR-0003Cu-88
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 11:49:55 -0400
Date: Fri, 22 Oct 2010 13:41:37 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] v2 Add drive_get_by_id
Message-ID: <20101022134137.63f56e76@doriath>
In-Reply-To: <1287716153-25305-2-git-send-email-ryanh@us.ibm.com>
References: <1287716153-25305-1-git-send-email-ryanh@us.ibm.com>
	<1287716153-25305-2-git-send-email-ryanh@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: Stefan Hajnoczi <stefan.hajnoczi@uk.ibm.com>, Anthony Liguori <aliguori@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>

On Thu, 21 Oct 2010 21:55:52 -0500
Ryan Harper <ryanh@us.ibm.com> wrote:

> Add a function to find a drive by id string.
> 
> Changes since v1:
> -Coding Style fix
> 
> Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
> ---
>  blockdev.c |   13 +++++++++++++
>  blockdev.h |    1 +
>  2 files changed, 14 insertions(+), 0 deletions(-)
> 
> diff --git a/blockdev.c b/blockdev.c
> index ff7602b..5fc3b9b 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -75,6 +75,19 @@ DriveInfo *drive_get(BlockInterfaceType type, int bus, int unit)
>      return NULL;
>  }
>  
> +DriveInfo *drive_get_by_id(const char *id)
> +{
> +    DriveInfo *dinfo;
> +
> +    QTAILQ_FOREACH(dinfo, &drives, next) {
> +        if (strcmp(id, dinfo->id)) {
> +            continue;
> +        }

Very minor, but the following allows you to drop a statement:

if (!strcmp()) {
  return dinfo;
}

> +        return dinfo;
> +    }
> +    return NULL;
> +}
> +
>  int drive_get_max_bus(BlockInterfaceType type)
>  {
>      int max_bus;
> diff --git a/blockdev.h b/blockdev.h
> index 653affc..19c6915 100644
> --- a/blockdev.h
> +++ b/blockdev.h
> @@ -38,6 +38,7 @@ DriveInfo *drive_get(BlockInterfaceType type, int bus, int unit);
>  int drive_get_max_bus(BlockInterfaceType type);
>  void drive_uninit(DriveInfo *dinfo);
>  DriveInfo *drive_get_by_blockdev(BlockDriverState *bs);
> +DriveInfo *drive_get_by_id(const char *id);
>  
>  QemuOpts *drive_add(const char *file, const char *fmt, ...) GCC_FMT_ATTR(2, 3);
>  DriveInfo *drive_init(QemuOpts *arg, int default_to_scsi, int *fatal_error);