From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34769 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P9K4x-0006Rl-Ed for qemu-devel@nongnu.org; Fri, 22 Oct 2010 12:02:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9Jsb-0003G9-7L for qemu-devel@nongnu.org; Fri, 22 Oct 2010 11:50:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P9Jsa-0003Ft-VL for qemu-devel@nongnu.org; Fri, 22 Oct 2010 11:50:05 -0400 Date: Fri, 22 Oct 2010 13:48:50 -0200 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH 0/2] v3 Decouple block device removal from device removal Message-ID: <20101022134850.083085dd@doriath> In-Reply-To: <1287716153-25305-1-git-send-email-ryanh@us.ibm.com> References: <1287716153-25305-1-git-send-email-ryanh@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ryan Harper Cc: Kevin Wolf , qemu-devel@nongnu.org, Markus Armbruster , Anthony Liguori , Stefan Hajnoczi , hch@lst.de On Thu, 21 Oct 2010 21:55:51 -0500 Ryan Harper wrote: > This patch series decouples the detachment of a block device from the removal > of the backing pci-device. Removal of a hotplugged pci device requires the > guest to respond before qemu tears down the block device. In some cases, the > guest may not respond leaving the guest with continued access to the block > device. > > The new monitor command, drive_unplug, will revoke a guests access to the > block device independently of the removal of the pci device. > > The first patch adds a new drive find method, the second patch implements the > monitor command and block layer changes. Reviewed the monitor part, I think we're waiting for Kevin's and/or Markus's ACK to get this merged? > > Changes since v2: > - Added QMP command for drive_unplug() > > Changes since v1: > - CodingStyle fixes > - Added qemu_aio_flush() to bdrv_unplug() > > Signed-off-by: Ryan Harper >