From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42152 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P9Is1-0001hi-Gg
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 10:45:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1P9Is0-0006Jm-1A
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 10:45:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53215)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1P9Irz-0006Jf-RG
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 10:45:23 -0400
Date: Fri, 22 Oct 2010 16:38:49 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce
	pushing attention button command
Message-ID: <20101022143849.GC23469@redhat.com>
References: <cover.1287562197.git.yamahata@valinux.co.jp>
	<2f5cb93039ab90a7b267334dd5e2e94b7a550b9f.1287562197.git.yamahata@valinux.co.jp>
	<20101020100011.GE10783@redhat.com>
	<m3lj5qxxws.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3lj5qxxws.fsf@blackfin.pond.sub.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: skandasa@cisco.com, lmr@redhat.com, etmartin@cisco.com, wexu2@cisco.com, qemu-devel@nongnu.org, Isaku Yamahata <yamahata@valinux.co.jp>, kraxel@redhat.com

On Fri, Oct 22, 2010 at 01:35:47PM +0200, Markus Armbruster wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> 
> > On Wed, Oct 20, 2010 at 05:18:56PM +0900, Isaku Yamahata wrote:
> >> glue pcie_push_attention_button command.
> >> 
> >> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> >
> > So as a high level command, I think we need to
> > think about how to tie this into pci_add/pci_del.
> > Right?
> [...]
> 
> Do we have consensus how our set of commands for hot plug should look
> like?  We talked about it, but did we reach consensus?  If yes, did we
> write it down somewhere?

I think for simple things yes:
- command to send hotplug notification to the guest
- command to immediately add/remove the device
- event to notify about guest ack
- way to poll status: did guest ack last command?

Existing ones will keep function:
- send notification and when acked remove device
- add device and send notification
These are useful for human monitor but maybe not
for management.


-- 
MST