From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] sparc32: convert debug printf statements to tracepoints
Date: Fri, 22 Oct 2010 16:22:03 +0100 [thread overview]
Message-ID: <20101022152203.GA14171@stefan-thinkpad.transitives.com> (raw)
In-Reply-To: <AANLkTikbhjwC5bF=n=1SAM4wZWRoRGsYEOEwBxdNUX8N@mail.gmail.com>
On Thu, Oct 21, 2010 at 08:13:51PM +0000, Blue Swirl wrote:
> Replace debug printf statements with tracepoints.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> There were problems with tracetool if the tracepoint string contained
> parentheses or brackets, so I removed those.
>
> hw/cs4231.c | 20 ++-------
> hw/eccmemctl.c | 46 +++++++++-------------
> hw/lance.c | 14 ++-----
> hw/slavio_intctl.c | 38 ++++++------------
> hw/slavio_misc.c | 51 ++++++++++---------------
> hw/slavio_timer.c | 49 ++++++++---------------
> hw/sparc32_dma.c | 42 ++++++--------------
> hw/sun4m.c | 18 ++------
> hw/sun4m_iommu.c | 33 ++++-----------
> trace-events | 108 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 10 files changed, 213 insertions(+), 206 deletions(-)
Acked-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Out of interest, why is %8.8x used instead of %08x? Is there a
difference in meaning or just style?
Stefan
next prev parent reply other threads:[~2010-10-22 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 20:13 [Qemu-devel] [PATCH] sparc32: convert debug printf statements to tracepoints Blue Swirl
2010-10-22 15:22 ` Stefan Hajnoczi [this message]
2010-10-22 17:32 ` [Qemu-devel] " Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022152203.GA14171@stefan-thinkpad.transitives.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).