From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34398 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P9JRX-00010D-I4
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 11:22:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1P9JRW-0006BW-Gh
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 11:22:07 -0400
Received: from mtagate2.uk.ibm.com ([194.196.100.162]:41490)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1P9JRW-0006BN-6z
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 11:22:06 -0400
Received: from d06nrmr1707.portsmouth.uk.ibm.com
	(d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225])
	by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id o9MFM4vq002323
	for <qemu-devel@nongnu.org>; Fri, 22 Oct 2010 15:22:04 GMT
Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com
	[9.149.37.212])
	by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id o9MFM4dH3436686
	for <qemu-devel@nongnu.org>; Fri, 22 Oct 2010 16:22:04 +0100
Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id o9MFM4Kp028655
	for <qemu-devel@nongnu.org>; Fri, 22 Oct 2010 09:22:04 -0600
Date: Fri, 22 Oct 2010 16:22:03 +0100
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Message-ID: <20101022152203.GA14171@stefan-thinkpad.transitives.com>
References: <AANLkTikbhjwC5bF=n=1SAM4wZWRoRGsYEOEwBxdNUX8N@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTikbhjwC5bF=n=1SAM4wZWRoRGsYEOEwBxdNUX8N@mail.gmail.com>
Subject: [Qemu-devel] Re: [PATCH] sparc32: convert debug printf statements
	to tracepoints
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Thu, Oct 21, 2010 at 08:13:51PM +0000, Blue Swirl wrote:
> Replace debug printf statements with tracepoints.
> 
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> There were problems with tracetool if the tracepoint string contained
> parentheses or brackets, so I removed those.
> 
>  hw/cs4231.c        |   20 ++-------
>  hw/eccmemctl.c     |   46 +++++++++-------------
>  hw/lance.c         |   14 ++-----
>  hw/slavio_intctl.c |   38 ++++++------------
>  hw/slavio_misc.c   |   51 ++++++++++---------------
>  hw/slavio_timer.c  |   49 ++++++++---------------
>  hw/sparc32_dma.c   |   42 ++++++--------------
>  hw/sun4m.c         |   18 ++------
>  hw/sun4m_iommu.c   |   33 ++++-----------
>  trace-events       |  108 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  10 files changed, 213 insertions(+), 206 deletions(-)

Acked-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Out of interest, why is %8.8x used instead of %08x?  Is there a
difference in meaning or just style?

Stefan