From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40960 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P9JXK-0000jj-1r
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 11:28:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1P9JXH-0007cn-T6
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 11:28:05 -0400
Received: from mtagate4.de.ibm.com ([195.212.17.164]:35112)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1P9JXH-0007bz-LR
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 11:28:03 -0400
Received: from d12nrmr1607.megacenter.de.ibm.com
	(d12nrmr1607.megacenter.de.ibm.com [9.149.167.49])
	by mtagate4.de.ibm.com (8.13.1/8.13.1) with ESMTP id o9MFS15r014438
	for <qemu-devel@nongnu.org>; Fri, 22 Oct 2010 15:28:01 GMT
Received: from d12av04.megacenter.de.ibm.com (d12av04.megacenter.de.ibm.com
	[9.149.165.229])
	by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id o9MFRxpi4137016
	for <qemu-devel@nongnu.org>; Fri, 22 Oct 2010 17:28:01 +0200
Received: from d12av04.megacenter.de.ibm.com (loopback [127.0.0.1])
	by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP
	id o9MFRxUK017340
	for <qemu-devel@nongnu.org>; Fri, 22 Oct 2010 17:27:59 +0200
Date: Fri, 22 Oct 2010 16:27:58 +0100
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Message-ID: <20101022152757.GB14171@stefan-thinkpad.transitives.com>
References: <20101021144929.7911128a@zephyr> <20101021151018.3d12b5f1@zephyr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101021151018.3d12b5f1@zephyr>
Subject: [Qemu-devel] Re: [RFC][PATCH 4/5] trace-event
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Prerna Saxena <prerna@linux.vnet.ibm.com>
Cc: Mahesh <mahesh@linux.vnet.ibm.com>, Ananth Narayan <ananth@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

On Thu, Oct 21, 2010 at 03:10:18PM +0530, Prerna Saxena wrote:
> trace-event : QMP interface to change state of a trace-event.
> (Analogous to hmp command : trace-event )
> 
> Signed-off-by: Prerna Saxena <prerna@linux.vnet.ibm.com>
> ---
>  qmp-commands.hx |   32 ++++++++++++++++++++++++++++++++
>  1 files changed, 32 insertions(+), 0 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 7e95f4e..f2008e8 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -761,6 +761,38 @@ Example:
> 
>  Note: This command must be issued before issuing any other command.
> 
> +EQMP
> +
> +    {
> +        .name       = "trace-event",
> +        .args_type  = "name:s,option:b",
> +        .params     = "name on|off",
> +        .help       = "changes state of a specific trace event",
> +        .user_print = monitor_user_noop,
> +        .mhandler.cmd_new = do_change_trace_event_state_qmp,
> +    },
> +
> +SQMP
> +trace-event
> +-----------
> +
> +Change state of a trace-event.

The name is a little odd because it has no verb.  How about
set-trace-event or enable-trace-event?

Stefan