From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45747 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P9Ldg-0006uo-4F
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 13:42:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1P9LUx-0003kE-Ni
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 13:33:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32714)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1P9LUx-0003k3-GH
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 13:33:47 -0400
Date: Fri, 22 Oct 2010 15:33:37 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] Silence compiler warning in json test
	case
Message-ID: <20101022153337.3a4c2ff3@doriath>
In-Reply-To: <m3aam6gndw.fsf@blackfin.pond.sub.org>
References: <1287756396-13100-1-git-send-email-lcapitulino@redhat.com>
	<1287756396-13100-3-git-send-email-lcapitulino@redhat.com>
	<m3aam6gndw.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org

On Fri, 22 Oct 2010 19:15:07 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > From: Jan Kiszka <jan.kiszka@web.de>
> >
> > This avoids
> >
> >     error: zero-length gnu_printf format string
> >
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  check-qjson.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/check-qjson.c b/check-qjson.c
> > index 0b60e45..64fcdcb 100644
> > --- a/check-qjson.c
> > +++ b/check-qjson.c
> > @@ -639,7 +639,9 @@ END_TEST
> >  
> >  START_TEST(empty_input)
> >  {
> > -    QObject *obj = qobject_from_json("");
> > +    const char *empty = "";
> > +
> > +    QObject *obj = qobject_from_json(empty);
> >      fail_unless(obj == NULL);
> >  }
> >  END_TEST
> 
> The warning is silly.  Printing nothing is unlikely to happen
> unintentionally, and is perfectly well-defined and portable.
> 
> Why make the code ugly to avoid a useless warning, when we can disable
> the warning?

You mean, disable it only for this specific case or QEMU wide?

If it's the former, please, submit a patch. Otherwise, this has been
discussed already and the conclusion was that the warning is
useful:

 http://www.mail-archive.com/qemu-devel@nongnu.org/msg44072.html

Honestly speaking, no matter what the conclusion is, what can not
happen is having code that doesn't compile in the tree. Either: we apply
this patch or revert the patch that broke the build.