From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39466 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P9OHH-0006G4-Bt for qemu-devel@nongnu.org; Fri, 22 Oct 2010 16:31:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9OHG-0003CC-77 for qemu-devel@nongnu.org; Fri, 22 Oct 2010 16:31:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P9OHG-0003Bk-0n for qemu-devel@nongnu.org; Fri, 22 Oct 2010 16:31:50 -0400 From: Alex Williamson Date: Fri, 22 Oct 2010 14:31:45 -0600 Message-ID: <20101022193845.10161.52907.stgit@s20.home> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH 0/2] msix: couple fixes List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mst@redhat.com Cc: alex.williamson@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org I've been porting the qemu vfio driver to use the common msix infrastructure and hit a couple issues. The first patch addresses the problem that a device may already have MSI-X capability setup and non-adjustable BARs, so msix_init should be able to use the existing capability instead of adding it's own. I'm surprised we need the second patch, as I'm not sure how things work today without it. We allocate msix_irq_entries within a KVM_CAP_IRQCHIP #ifdef. This should be pulled in from kvm.h, if we have CONFIG_KVM, but that's pulled in from config-target.h, which we don't include. We can add config.h to msix.c, but that only works if the msix object is in Makefile.target instead of Makefile.objs. Feel free to fix this differently, but I think something is wrong there. Thanks, Alex --- Alex Williamson (2): msix: Pull in config.h for CONFIG_KVM msix: Allow msix_init on a device with existing MSI-X capability Makefile.objs | 2 -- Makefile.target | 1 + hw/msix.c | 68 ++++++++++++++++++++++++++++++++----------------------- 3 files changed, 40 insertions(+), 31 deletions(-)