From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60598 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P9i0w-0003i2-TW
	for qemu-devel@nongnu.org; Sat, 23 Oct 2010 13:36:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1P9i0v-0001GA-R2
	for qemu-devel@nongnu.org; Sat, 23 Oct 2010 13:36:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22112)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1P9i0v-0001G0-I0
	for qemu-devel@nongnu.org; Sat, 23 Oct 2010 13:36:17 -0400
Date: Sat, 23 Oct 2010 19:29:45 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20101023172945.GD11488@redhat.com>
References: <20101022193845.10161.52907.stgit@s20.home>
	<20101022204037.10161.83407.stgit@s20.home>
	<20101023161633.GA11488@redhat.com> <1287852763.5129.5.camel@x201>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1287852763.5129.5.camel@x201>
Subject: [Qemu-devel] Re: [PATCH 2/2] msix: Pull in config.h for CONFIG_KVM
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On Sat, Oct 23, 2010 at 10:52:43AM -0600, Alex Williamson wrote:
> On Sat, 2010-10-23 at 18:16 +0200, Michael S. Tsirkin wrote:
> > On Fri, Oct 22, 2010 at 02:40:39PM -0600, Alex Williamson wrote:
> > > We need to pull in config.h or else kvm.h doesn't pull in
> > > linux/config.h, which we need if we ever want KVM_CAP_IRQCHIP
> > > defined.  This requires moving the object over to Makefile.target
> > > or else we can't find config-target.h
> > > 
> > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> > 
> > Why? We just moved it from .target to .objs, see
> > 889e30cc18e21f2091b77267dca8096d7dd34f8b.
> 
> Maybe that's why it used to work.  When building in the qemu-kvm.git
> tree, I'm not getting CONFIG_KVM defined, which means I'm not getting
> KVM_CAP_IRQCHIP defined, which results in msix_irq_entries not being
> allocated.  Then when I call msix_vector_use, I get a seg fault.
> Something is broken there.  Thanks,
> 
> Alex

This is hopefully fixed in the latest bits.
bd8b215bce453706c3951460cc7e6627ccb90314

-- 
MST