From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53913 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PAIWd-0000w2-3C
	for qemu-devel@nongnu.org; Mon, 25 Oct 2010 04:35:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PAIAB-0004Te-GP
	for qemu-devel@nongnu.org; Mon, 25 Oct 2010 04:12:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47807)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PAIAB-0004TY-A8
	for qemu-devel@nongnu.org; Mon, 25 Oct 2010 04:12:15 -0400
Date: Mon, 25 Oct 2010 10:05:35 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20101025080535.GA5454@redhat.com>
References: <20101025054941.GA3223@redhat.com>
	<20101025064401.GU31309@valinux.co.jp>
	<20101025064638.GA4211@redhat.com>
	<20101025070426.GW31309@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101025070426.GW31309@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH RFC] pcie: clean up hot plug notification
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

On Mon, Oct 25, 2010 at 04:04:26PM +0900, Isaku Yamahata wrote:
> On Mon, Oct 25, 2010 at 08:46:38AM +0200, Michael S. Tsirkin wrote:
> > On Mon, Oct 25, 2010 at 03:44:01PM +0900, Isaku Yamahata wrote:
> > > On Mon, Oct 25, 2010 at 07:49:41AM +0200, Michael S. Tsirkin wrote:
> > > > Simplify logic for hotplug notification, by tracking state of the
> > > > logical interrupt condition.  We then simply use this variable to make
> > > > the interrupt decision, according to spec.
> > > > 
> > > > API is made cleaner as we no longer force users to pass in
> > > > old slot control value.
> > > 
> > > Thank you for looking into it.
> > > Some comments below.
> > 
> > Thanks! Care fixing up the remaining issues?
> > I will fold the fixup in.
> 
> Will do.

One other thing: I think when we validate data on load
need to take w1c mask into account, not just wmask.

> yamahata