From: Gleb Natapov <gleb@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] Add get_dev_path callback to ISA bus.
Date: Mon, 25 Oct 2010 20:06:10 +0200 [thread overview]
Message-ID: <20101025180610.GA877@redhat.com> (raw)
In-Reply-To: <m3pquyi2fu.fsf@blackfin.pond.sub.org>
On Mon, Oct 25, 2010 at 07:53:41PM +0200, Markus Armbruster wrote:
> Gleb Natapov <gleb@redhat.com> writes:
>
> > On Mon, Oct 25, 2010 at 05:10:15PM +0200, Markus Armbruster wrote:
> >> Gleb Natapov <gleb@redhat.com> writes:
> >>
> >> > PCI bus already has one. For ISA bus this patch series uses device's
> >> > ioports to uniquely describe it. For isa-ide, for example, get_dev_path
> >> > method returns:
> >> > 01f0-01f7,03f6 for first IDE controller
> >> > 0170-0177,0376 for second one
> >>
> >> Any I/O port used by the device identifies it. I'd say a common
> >> identifier is the "I/O base", the lowest I/O port used.
> > So use only first port from the string. More information is better then
> > less information. You can always drop information you do not need.
>
> I'd prefer canonical bus addresses to be terse. It's not the place to
> give additional information.
I'd prefer them to give full info but not more. I don't see why you
point is more valid then mine.
--
Gleb.
next prev parent reply other threads:[~2010-10-25 18:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 14:02 [Qemu-devel] [PATCH 0/2] Add get_dev_path callback to ISA bus Gleb Natapov
2010-10-24 14:02 ` [Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev Gleb Natapov
2010-10-25 15:06 ` Markus Armbruster
2010-10-25 16:58 ` Gleb Natapov
2010-10-25 18:01 ` Markus Armbruster
2010-10-25 18:15 ` Gleb Natapov
2010-10-26 9:49 ` Markus Armbruster
2010-10-26 10:29 ` Gleb Natapov
2010-10-24 14:02 ` [Qemu-devel] [PATCH 2/2] Add get_dev_path callback to ISA bus " Gleb Natapov
2010-10-25 15:10 ` [Qemu-devel] [PATCH 0/2] Add get_dev_path callback to ISA bus Markus Armbruster
2010-10-25 17:00 ` Gleb Natapov
2010-10-25 17:53 ` Markus Armbruster
2010-10-25 18:06 ` Gleb Natapov [this message]
2010-10-26 9:57 ` Markus Armbruster
2010-10-26 10:38 ` Gleb Natapov
2010-10-26 11:04 ` Markus Armbruster
2010-10-26 11:13 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101025180610.GA877@redhat.com \
--to=gleb@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).