From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57133 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PASPh-0003iL-Ad for qemu-devel@nongnu.org; Mon, 25 Oct 2010 15:08:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PAS5q-0004nF-A4 for qemu-devel@nongnu.org; Mon, 25 Oct 2010 14:48:27 -0400 Received: from e2.ny.us.ibm.com ([32.97.182.142]:49916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PAS5q-0004n9-6U for qemu-devel@nongnu.org; Mon, 25 Oct 2010 14:48:26 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by e2.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o9PIGE68031425 for ; Mon, 25 Oct 2010 14:16:14 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o9PIVrM1218440 for ; Mon, 25 Oct 2010 14:31:53 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o9PIVqFf004867 for ; Mon, 25 Oct 2010 16:31:53 -0200 Date: Mon, 25 Oct 2010 13:31:48 -0500 From: Ryan Harper Subject: Re: [Qemu-devel] [PATCH 0/2] v3 Decouple block device removal from device removal Message-ID: <20101025183148.GA22904@us.ibm.com> References: <1287716153-25305-1-git-send-email-ryanh@us.ibm.com> <20101022134850.083085dd@doriath> <4CC1B7AA.9090506@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CC1B7AA.9090506@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, Markus Armbruster , Anthony Liguori , Ryan Harper , Stefan Hajnoczi , Luiz Capitulino , hch@lst.de * Kevin Wolf [2010-10-22 11:12]: > Am 22.10.2010 17:48, schrieb Luiz Capitulino: > > On Thu, 21 Oct 2010 21:55:51 -0500 > > Ryan Harper wrote: > > > >> This patch series decouples the detachment of a block device from the removal > >> of the backing pci-device. Removal of a hotplugged pci device requires the > >> guest to respond before qemu tears down the block device. In some cases, the > >> guest may not respond leaving the guest with continued access to the block > >> device. > >> > >> The new monitor command, drive_unplug, will revoke a guests access to the > >> block device independently of the removal of the pci device. > >> > >> The first patch adds a new drive find method, the second patch implements the > >> monitor command and block layer changes. > > > > Reviewed the monitor part, I think we're waiting for Kevin's and/or > > Markus's ACK to get this merged? > > Yes, I'm waiting for Markus' comments before applying this. > > Maybe we shouldn't add this to QMP yet, drive_add doesn't exist there > either because we want to do it right with blockdev_add/del. On the > other hand Markus should know much better than me what the right thing > would look like - if he says that this interface will work with whatever > we're going to get with blockdev_*, I'm fine with merging it. I sent a new series moving the QMP command out into a separate patch so if we decide to not pick it up at this time you can just drop it. The libvirt-side change is being picked up, waiting for some testing to complete, any chance for some time from Markus to review this week? -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ryanh@us.ibm.com