From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54497 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PAjbY-0001b2-Hh
	for qemu-devel@nongnu.org; Tue, 26 Oct 2010 09:30:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1PAjbX-0001Zd-C7
	for qemu-devel@nongnu.org; Tue, 26 Oct 2010 09:30:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28229)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1PAjbX-0001ZZ-3D
	for qemu-devel@nongnu.org; Tue, 26 Oct 2010 09:30:19 -0400
Date: Tue, 26 Oct 2010 15:30:16 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/5] Keep track of ISA ports ISA device is
	using in qdev.
Message-ID: <20101026133016.GH26191@redhat.com>
References: <1288090091-25874-1-git-send-email-gleb@redhat.com>
	<1288090091-25874-2-git-send-email-gleb@redhat.com>
	<4CC6D6BA.8000007@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CC6D6BA.8000007@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On Tue, Oct 26, 2010 at 08:25:14AM -0500, Anthony Liguori wrote:
> On 10/26/2010 05:48 AM, Gleb Natapov wrote:
> >Store all io ports used by device in ISADevice structure.
> >
> >Signed-off-by: Gleb Natapov<gleb@redhat.com>
> >---
> >  hw/cs4231a.c     |    1 +
> >  hw/fdc.c         |    3 +++
> >  hw/gus.c         |    4 ++++
> >  hw/ide/isa.c     |    2 ++
> >  hw/isa-bus.c     |   25 +++++++++++++++++++++++++
> >  hw/isa.h         |    4 ++++
> >  hw/m48t59.c      |    1 +
> >  hw/mc146818rtc.c |    1 +
> >  hw/ne2000-isa.c  |    3 +++
> >  hw/parallel.c    |    5 +++++
> >  hw/pckbd.c       |    3 +++
> >  hw/sb16.c        |    4 ++++
> >  hw/serial.c      |    1 +
> >  13 files changed, 57 insertions(+), 0 deletions(-)
> >
> >diff --git a/hw/cs4231a.c b/hw/cs4231a.c
> >index 4d5ce5c..598f032 100644
> >--- a/hw/cs4231a.c
> >+++ b/hw/cs4231a.c
> >@@ -645,6 +645,7 @@ static int cs4231a_initfn (ISADevice *dev)
> >      isa_init_irq (dev,&s->pic, s->irq);
> >
> >      for (i = 0; i<  4; i++) {
> >+        isa_init_ioport(dev, i);
> >          register_ioport_write (s->port + i, 1, 1, cs_write, s);
> >          register_ioport_read (s->port + i, 1, 1, cs_read, s);
> 
> A better way to do this would be to introduce isa_register_ioport.
> 

That what Markus proposed and, in principal, I agree. I would like to
keep that out from this path series, but if it is not a big churn and
maintainers insists I can look at it. I need to do something anyway
while Markus is cooling down :)

> We can take Avi's series first since that probably makes this easier
> to implement.
> 
It is ready to go in, no?

--
			Gleb.