From: Isaku Yamahata <yamahata@valinux.co.jp>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: skandasa@cisco.com, adnan@khaleel.us, etmartin@cisco.com,
qemu-devel@nongnu.org, wexu2@cisco.com
Subject: [Qemu-devel] Re: [PATCH v7 2/6] pcie/aer: helper functions for pcie aer capability
Date: Wed, 3 Nov 2010 10:24:30 +0900 [thread overview]
Message-ID: <20101103012430.GA26077@valinux.co.jp> (raw)
In-Reply-To: <20101102125712.GB29655@redhat.com>
On Tue, Nov 02, 2010 at 02:57:12PM +0200, Michael S. Tsirkin wrote:
> > +static void pcie_aer_clear_error(PCIDevice *dev);
> > +static void pcie_aer_msg(PCIDevice *dev, const PCIEAERMsg *msg);
> > +
>
> so what exactly is the order of calls that makes
> removing the forward declarations impractical?
> Is there a recursive call? If yes I'd like to
> see it documented much better.
Why do you think forward declaration is so bad?
I don't see any such consensus and I don't think they aren't
accused generally like goto.
Can you please elaborate why you're trying so hard to prevent it?
--
yamahata
next prev parent reply other threads:[~2010-11-03 1:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 9:32 [Qemu-devel] [PATCH v7 0/6] pcie port switch emulators Isaku Yamahata
2010-11-02 9:32 ` [Qemu-devel] [PATCH v7 1/6] pcie_regs.h: more constants Isaku Yamahata
2010-11-02 9:32 ` [Qemu-devel] [PATCH v7 2/6] pcie/aer: helper functions for pcie aer capability Isaku Yamahata
2010-11-02 12:57 ` [Qemu-devel] " Michael S. Tsirkin
2010-11-03 1:24 ` Isaku Yamahata [this message]
2010-11-03 7:30 ` Michael S. Tsirkin
2010-11-15 7:35 ` Isaku Yamahata
2010-11-15 7:44 ` Michael S. Tsirkin
2010-11-02 13:54 ` Michael S. Tsirkin
2010-11-02 9:32 ` [Qemu-devel] [PATCH v7 3/6] pcie/aer: glue aer error injection into qemu monitor Isaku Yamahata
2010-11-02 12:10 ` [Qemu-devel] " Michael S. Tsirkin
2010-11-02 9:32 ` [Qemu-devel] [PATCH v7 4/6] ioh3420: support aer Isaku Yamahata
2010-11-02 9:32 ` [Qemu-devel] [PATCH v7 5/6] x3130/upstream: " Isaku Yamahata
2010-11-02 9:32 ` [Qemu-devel] [PATCH v7 6/6] x3130/downstream: " Isaku Yamahata
2010-11-02 14:05 ` [Qemu-devel] Re: [PATCH v7 0/6] pcie port switch emulators Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101103012430.GA26077@valinux.co.jp \
--to=yamahata@valinux.co.jp \
--cc=adnan@khaleel.us \
--cc=etmartin@cisco.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=skandasa@cisco.com \
--cc=wexu2@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).