qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images
Date: Thu, 4 Nov 2010 23:22:15 +0100	[thread overview]
Message-ID: <20101104222214.GC30050@os.inf.tu-dresden.de> (raw)


A via -kernel supplied x86_64 ELF image is being started in 32bit mode.
Detect and exit if a 64bit image has been supplied.

Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Acked-by: Alexander Graf <agraf@suse.de>
---
 hw/multiboot.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/hw/multiboot.c b/hw/multiboot.c
index f9097a2..e710bbb 100644
--- a/hw/multiboot.c
+++ b/hw/multiboot.c
@@ -171,6 +171,12 @@ int load_multiboot(void *fw_cfg,
         uint64_t elf_low, elf_high;
         int kernel_size;
         fclose(f);
+
+        if (((struct elf64_hdr*)header)->e_machine == EM_X86_64) {
+            fprintf(stderr, "Cannot load x86-64 image, give a 32bit one.\n");
+            exit(1);
+        }
+
         kernel_size = load_elf(kernel_filename, NULL, NULL, &elf_entry,
                                &elf_low, &elf_high, 0, ELF_MACHINE, 0);
         if (kernel_size < 0) {
-- 
1.7.2.3


Adam
-- 
Adam                 adam@os.inf.tu-dresden.de
  Lackorzynski         http://os.inf.tu-dresden.de/~adam/

             reply	other threads:[~2010-11-04 22:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-04 22:22 Adam Lackorzynski [this message]
2010-11-16 20:09 ` [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images Anthony Liguori
  -- strict thread matches above, loose matches on Subject: below --
2010-09-25  8:51 Adam Lackorzynski
2010-09-02 20:28 Adam Lackorzynski
2010-08-19 11:24 Adam Lackorzynski
2010-08-19 11:27 ` Alexander Graf
2010-08-19 11:36   ` Adam Lackorzynski
2010-08-19 11:40     ` Alexander Graf
2010-08-19 12:32       ` Adam Lackorzynski
2010-08-19 12:34         ` Alexander Graf
2010-08-19 12:49           ` Adam Lackorzynski
2010-08-19 13:01             ` Alexander Graf
2010-08-20 18:47             ` Rene Rebe
2010-08-19 13:02 ` Avi Kivity
2010-08-19 13:57   ` Alexander Graf
2010-08-19 14:05     ` Avi Kivity
2010-08-19 14:10       ` Alexander Graf
2010-08-19 14:12         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101104222214.GC30050@os.inf.tu-dresden.de \
    --to=adam@os.inf.tu-dresden.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).