From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48108 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PFB8o-0005pM-Vk
	for qemu-devel@nongnu.org; Sun, 07 Nov 2010 14:43:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jwm@horde.net>) id 1PFB8n-00020E-Bk
	for qemu-devel@nongnu.org; Sun, 07 Nov 2010 14:43:02 -0500
Received: from boost.horde.net ([69.55.65.181]:52780)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jwm@horde.net>) id 1PFB8n-0001zp-9Q
	for qemu-devel@nongnu.org; Sun, 07 Nov 2010 14:43:01 -0500
Date: Sun, 7 Nov 2010 14:42:59 -0500
From: John Morrissey <jwm@horde.net>
Message-ID: <20101107194259.GA6586@boost.horde.net>
References: <1289144652-23463-1-git-send-email-jwm@horde.net>
	<BF187BF6-6B84-4077-9998-25110557DA5C@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <BF187BF6-6B84-4077-9998-25110557DA5C@web.de>
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH] Overwrite argv to set process title,
 eliminating 16-character prctl() limit.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <andreas.faerber@web.de>
Cc: qemu-devel@nongnu.org

On Sun, Nov 07, 2010 at 07:27:22PM +0100, Andreas F=E4rber wrote:
> Am 07.11.2010 um 16:44 schrieb John Morrissey:
> >@@ -149,20 +145,24 @@ char *os_find_datadir(const char *argv0)
> >#undef SHARE_SUFFIX
> >#undef BUILD_SUFFIX
> >
> >-void os_set_proc_name(const char *s)
> >+void os_set_proc_name(int argc, char **argv, const char *name)
> >{
> >-#if defined(PR_SET_NAME)
> >-    char name[16];
> >-    if (!s)
> >+#ifdef CONFIG_LINUX
>=20
> Is PR_SET_NAME defined outside Linux? If so, then your patch removes
> the limited functionality for those platforms completely.

PR_SET_NAME is defined in sys/prctl.h which, before this patch, was
conditionally included only on Linux platforms (CONFIG_LINUX).

Additionally, prctl(2) says:

  CONFORMING TO
         This  call  is  Linux-specific.

john
--=20
John Morrissey          _o            /\         ----  __o
jwm@horde.net        _-< \_          /  \       ----  <  \,
www.horde.net/    __(_)/_(_)________/    \_______(_) /_(_)__