From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36770 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFZNW-0003Is-BX for qemu-devel@nongnu.org; Mon, 08 Nov 2010 16:35:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFZ0Y-00012O-HD for qemu-devel@nongnu.org; Mon, 08 Nov 2010 16:12:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18697) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFZ0Y-00012B-AH for qemu-devel@nongnu.org; Mon, 08 Nov 2010 16:12:06 -0500 Date: Mon, 8 Nov 2010 23:12:02 +0200 From: Gleb Natapov Message-ID: <20101108211202.GF19863@redhat.com> References: <1288525209-3303-1-git-send-email-gleb@redhat.com> <1288525209-3303-8-git-send-email-gleb@redhat.com> <20101108171737.GA8498@redhat.com> <20101108172950.GB19863@redhat.com> <20101108210017.GC10777@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101108210017.GC10777@redhat.com> Subject: [Qemu-devel] Re: [PATCHv2 7/8] Change pci bus get_dev_path callback to print only slot and func List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: blauwirbel@gmail.com, alex.williamson@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, armbru@redhat.com On Mon, Nov 08, 2010 at 11:00:17PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 07:29:50PM +0200, Gleb Natapov wrote: > > > This will make it compatible with existing code and generally > > > what users expect. > > > > > It will drop domain and bus number part anyway. > > Yes but the proposal was to add 0000:00: in front to > make it have the expected format for most users. > I am not interesting in hacks. I do not know who are those most users you are talking about and why they expect 0000:00: in front of something. Anyway, as I said, I moved to use another callback so you can do whatever you want with get_dev_path. -- Gleb.