From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48632 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PFhyp-0003w0-Me
	for qemu-devel@nongnu.org; Tue, 09 Nov 2010 01:46:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1PFhyh-0007rb-LL
	for qemu-devel@nongnu.org; Tue, 09 Nov 2010 01:46:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:29056)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1PFhyh-0007rX-DJ
	for qemu-devel@nongnu.org; Tue, 09 Nov 2010 01:46:47 -0500
Date: Tue, 9 Nov 2010 08:46:43 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20101109064643.GC9036@redhat.com>
References: <20100915163144.GM3008@redhat.com>
	<20101108235937.GA12701@morn.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101108235937.GA12701@morn.localdomain>
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH] fix virtio-blk failure after
	reboot
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: seabios@seabios.org, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

On Mon, Nov 08, 2010 at 06:59:37PM -0500, Kevin O'Connor wrote:
> On Wed, Sep 15, 2010 at 06:31:44PM +0200, Gleb Natapov wrote:
> > vring_virtqueue should be zeroed otherwise old values will be reused
> > after reboot.
> > 
> > Signed-off-by: Gleb Natapov <gleb@redhat.com>
> > diff --git a/src/virtio-blk.c b/src/virtio-blk.c
> > index 34d7863..7a25826 100644
> > --- a/src/virtio-blk.c
> > +++ b/src/virtio-blk.c
> > @@ -109,6 +109,7 @@ init_virtio_blk(u16 bdf)
> >          goto fail;
> >      }
> >      memset(vdrive_g, 0, sizeof(*vdrive_g));
> > +    memset(vq, 0, sizeof(*vq));
> >      vdrive_g->drive.type = DTYPE_VIRTIO;
> >      vdrive_g->drive.cntl_id = bdf;
> >      vdrive_g->vq = vq;
> 
> This didn't make it into SeaBIOS v0.6.1.  Should we add this to the
> stable branch as v0.6.1.2?  Any other bugfixes that need to go in to
> the stable branch (maybe Isaku's pci overflow patches)?
> 
Yes. Please add it to stable branch.

--
			Gleb.