From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34631 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PFlX0-0004m4-HM
	for qemu-devel@nongnu.org; Tue, 09 Nov 2010 05:34:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1PFlWz-0007g0-IF
	for qemu-devel@nongnu.org; Tue, 09 Nov 2010 05:34:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57449)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1PFlWz-0007fc-8H
	for qemu-devel@nongnu.org; Tue, 09 Nov 2010 05:34:25 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oA9AYO02022795
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 9 Nov 2010 05:34:24 -0500
Date: Tue, 9 Nov 2010 12:34:22 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Out off array access in usb-net
Message-ID: <20101109103422.GN9036@redhat.com>
References: <20101109073653.GF9036@redhat.com>
	<m3eiaun8s1.fsf@blackfin.pond.sub.org>
	<20101109093901.GM9036@redhat.com>
	<m3iq06hkdw.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3iq06hkdw.fsf@blackfin.pond.sub.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, Nov 09, 2010 at 11:16:43AM +0100, Markus Armbruster wrote:
> Gleb Natapov <gleb@redhat.com> writes:
> 
> > On Tue, Nov 09, 2010 at 10:30:54AM +0100, Markus Armbruster wrote:
> >> Gleb Natapov <gleb@redhat.com> writes:
> >> 
> >> > Properly check array bounds before accessing array element.
> >> 
> >> Impact?
> >> 
> > Gapping security hole for those unfortunate enough to use usb-net?
> 
> Doesn't that bit of information belong in the commit message.
> 
Some people prefer not to put such information into commit message.

> >> Apply to stable as well?
> >> 
> > Definitely. Actually for me Windows7 crashed when usb-net is present.
> 
> And that as well.
> 
> Good catch!

--
			Gleb.