[Qemu-devel] Re: [PATCHv3 00/14] boot order specification

[Gleb Natapov <gleb@redhat.com>]

On Wed, Nov 10, 2010 at 06:08:56PM +0000, Blue Swirl wrote:
> On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov <gleb@redhat.com> wrote:
> > This is current sate of the patch series for people to comment on.
> > I am using open firmware naming scheme to specify device path names.
> >
> > Names look like this on pci machine:
> > /pci@i0cf8/ide@1,1/drive@1/disk@0
> > /pci@i0cf8/isa@1/fdc@03f1/floppy@1
> > /pci@i0cf8/isa@1/fdc@03f1/floppy@0
> > /pci@i0cf8/ide@1,1/drive@1/disk@1
> > /pci@i0cf8/ide@1,1/drive@0/disk@0
> > /pci@i0cf8/scsi@3/disk@0
> > /pci@i0cf8/ethernet@4/ethernet-phy@0
> > /pci@i0cf8/ethernet@5/ethernet-phy@0
> > /pci@i0cf8/ide@1,1/drive@0/disk@1
> > /pci@i0cf8/isa@1/ide@01e8/drive@0/disk@0
> > /pci@i0cf8/usb@1,2/network@0/ethernet@0
> > /pci@i0cf8/usb@1,2/hub@1/network@0/ethernet@0
> >
> > and on isa machine:
> > /isa/ide@0170/drive@0/disk@0
> > /isa/fdc@03f1/floppy@1
> > /isa/fdc@03f1/floppy@0
> > /isa/ide@0170/drive@0/disk@1
> >
> >
> > Instead of using get_dev_path() callback I introduces another one
> > get_fw_dev_path. Unfortunately the way get_dev_path() callback is used
> > in migration code makes it hard to reuse it for other purposes. First
> > of all it is not called recursively so caller expects it to provide
> > unique name by itself. Device path though is inherently recursive. Each
> > individual element may not be unique, but the whole path will be. On
> > the other hand to call get_dev_path() recursively in migration code we
> > should implement it for all possible buses first. Other problem is
> > compatibility. If we change get_dev_path() output format now we will not
> > be able to migrate from old qemu to new one without some additional
> > compatibility layer.
> >
> > Gleb Natapov (14):
> >  Introduce fw_name field to DeviceInfo structure.
> >  Introduce new BusInfo callback get_fw_dev_path.
> >  Keep track of ISA ports ISA device is using in qdev.
> >  Add get_fw_dev_path callback to ISA bus in qdev.
> >  Store IDE bus id in IDEBus structure for easy access.
> >  Add get_fw_dev_path callback to IDE bus.
> >  Add get_dev_path callback for system bus.
> >  Add get_fw_dev_path callback for pci bus.
> >  Record which USBDevice USBPort belongs too.
> >  Add get_dev_path callback for usb bus.
> >  Add bootindex parameter to net/block/fd device
> >  Add bootindex parameter to pci assigned device.
> >  Add notifier that will be called when machine is fully created.
> >  Pass boot device list to firmware.
> 
> Nice, but the patches don't apply, for example
> hw/device-assingment.[ch] do not exist.
Device assignment one is for qemu-kvm. That is why I
made it separate and didn't fold into patch 11. Just drop it.

--
			Gleb.