From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54530 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PGUDa-0004Yr-41
	for qemu-devel@nongnu.org; Thu, 11 Nov 2010 05:17:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1PGUDZ-0002Tx-7A
	for qemu-devel@nongnu.org; Thu, 11 Nov 2010 05:17:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:12913)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1PGUDY-0002Tj-V0
	for qemu-devel@nongnu.org; Thu, 11 Nov 2010 05:17:21 -0500
Date: Thu, 11 Nov 2010 12:17:17 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20101111101717.GW9036@redhat.com>
References: <1289409261-5418-1-git-send-email-gleb@redhat.com>
	<1289409261-5418-9-git-send-email-gleb@redhat.com>
	<20101110173412.GE3891@redhat.com> <4CDBC045.3070902@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CDBC045.3070902@redhat.com>
Subject: [Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for
	pci bus.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, armbru@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, alex.williamson@redhat.com

On Thu, Nov 11, 2010 at 11:07:01AM +0100, Gerd Hoffmann wrote:
> On 11/10/10 18:34, Michael S. Tsirkin wrote:
> >On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote:
> >>
> >>Signed-off-by: Gleb Natapov<gleb@redhat.com>
> >
> >Good stuff. We should also consider using this for
> >CLI and monitor. Some comments below.
> 
> Oh, we already have a table to map pci classes to descriptions for
> 'info pci'.  I'd strongly suggest to just add the fw names to that
> table instead of creating a second one ...
> 
Do you mean pci_class_descriptions? For some classes open firmware spec
defines single name for all subclasses. For instance all 0Axx should be
called "dock" no matter what xx is. This can't be encoded in a simple
table.

--
			Gleb.