From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: kvm@vger.kernel.org, Gleb Natapov <gleb@redhat.com>,
armbru@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com,
alex.williamson@redhat.com
Subject: [Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.
Date: Thu, 11 Nov 2010 17:05:11 +0200 [thread overview]
Message-ID: <20101111150511.GF25692@redhat.com> (raw)
In-Reply-To: <4CDBC045.3070902@redhat.com>
On Thu, Nov 11, 2010 at 11:07:01AM +0100, Gerd Hoffmann wrote:
> On 11/10/10 18:34, Michael S. Tsirkin wrote:
> >On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote:
> >>
> >>Signed-off-by: Gleb Natapov<gleb@redhat.com>
> >
> >Good stuff. We should also consider using this for
> >CLI and monitor. Some comments below.
>
> Oh, we already have a table to map pci classes to descriptions for
> 'info pci'.
You remind me, that one must be fixed to use names from
pci_ids.h
> I'd strongly suggest to just add the fw names to that
> table instead of creating a second one ...
>
> cheers,
> Gerd
No, I mean the path.
We are currently passing domain:bus:slot.function
to point at a device and we know it's broken for
nested bridges and kind of broken for multiple domains.
It's a bug that we must fix.
Class names aren't that interesting to me,
and I'd be just as happy with packing these into 2 tables as a single
one personally, it all seems to be a matter of style.
--
MST
next prev parent reply other threads:[~2010-11-11 15:05 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 17:14 [Qemu-devel] [PATCHv3 00/14] boot order specification Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 01/14] Introduce fw_name field to DeviceInfo structure Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 02/14] Introduce new BusInfo callback get_fw_dev_path Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 03/14] Keep track of ISA ports ISA device is using in qdev Gleb Natapov
2010-11-11 10:14 ` [Qemu-devel] " Gerd Hoffmann
2010-11-11 10:22 ` Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 04/14] Add get_fw_dev_path callback to ISA bus " Gleb Natapov
2010-11-10 18:34 ` [Qemu-devel] " Blue Swirl
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 05/14] Store IDE bus id in IDEBus structure for easy access Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 06/14] Add get_fw_dev_path callback to IDE bus Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 07/14] Add get_dev_path callback for system bus Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus Gleb Natapov
2010-11-10 17:34 ` [Qemu-devel] " Michael S. Tsirkin
2010-11-10 18:02 ` Gleb Natapov
2010-11-10 18:21 ` Michael S. Tsirkin
2010-11-10 18:25 ` Blue Swirl
2010-11-10 18:33 ` Gleb Natapov
2010-11-11 10:07 ` Gerd Hoffmann
2010-11-11 10:17 ` Gleb Natapov
2010-11-11 11:00 ` Gerd Hoffmann
2010-11-11 15:05 ` Michael S. Tsirkin [this message]
2010-11-11 16:07 ` Gleb Natapov
2010-11-11 17:14 ` Michael S. Tsirkin
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 09/14] Record which USBDevice USBPort belongs too Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 10/14] Add get_dev_path callback for usb bus Gleb Natapov
2010-11-10 18:37 ` [Qemu-devel] " Blue Swirl
2010-11-10 19:11 ` Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 11/14] Add bootindex parameter to net/block/fd device Gleb Natapov
2010-11-10 18:32 ` [Qemu-devel] " Blue Swirl
2010-11-10 18:48 ` Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 12/14] Add bootindex parameter to pci assigned device Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 13/14] Add notifier that will be called when machine is fully created Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 14/14] Pass boot device list to firmware Gleb Natapov
2010-11-10 18:50 ` [Qemu-devel] " Blue Swirl
2010-11-10 19:11 ` Blue Swirl
2010-11-10 19:16 ` Gleb Natapov
2010-11-10 19:20 ` Blue Swirl
2010-11-11 7:03 ` Gleb Natapov
2010-11-10 18:08 ` [Qemu-devel] Re: [PATCHv3 00/14] boot order specification Blue Swirl
2010-11-10 18:19 ` Gleb Natapov
2010-11-11 10:21 ` Gerd Hoffmann
2010-11-11 18:41 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101111150511.GF25692@redhat.com \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=gleb@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).