From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59913 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PGajs-0008QO-Dz
	for qemu-devel@nongnu.org; Thu, 11 Nov 2010 12:15:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PGaje-0001AM-9X
	for qemu-devel@nongnu.org; Thu, 11 Nov 2010 12:14:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33502)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PGaje-0001AA-2m
	for qemu-devel@nongnu.org; Thu, 11 Nov 2010 12:14:54 -0500
Date: Thu, 11 Nov 2010 19:14:44 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20101111171444.GB30171@redhat.com>
References: <1289409261-5418-1-git-send-email-gleb@redhat.com>
	<1289409261-5418-9-git-send-email-gleb@redhat.com>
	<20101110173412.GE3891@redhat.com> <4CDBC045.3070902@redhat.com>
	<20101111150511.GF25692@redhat.com>
	<20101111160753.GB7948@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101111160753.GB7948@redhat.com>
Subject: [Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for
	pci bus.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org, armbru@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, alex.williamson@redhat.com, Gerd Hoffmann <kraxel@redhat.com>

On Thu, Nov 11, 2010 at 06:07:53PM +0200, Gleb Natapov wrote:
> On Thu, Nov 11, 2010 at 05:05:11PM +0200, Michael S. Tsirkin wrote:
> > On Thu, Nov 11, 2010 at 11:07:01AM +0100, Gerd Hoffmann wrote:
> > > On 11/10/10 18:34, Michael S. Tsirkin wrote:
> > > >On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote:
> > > >>
> > > >>Signed-off-by: Gleb Natapov<gleb@redhat.com>
> > > >
> > > >Good stuff. We should also consider using this for
> > > >CLI and monitor. Some comments below.
> > > 
> > > Oh, we already have a table to map pci classes to descriptions for
> > > 'info pci'.
> > 
> > You remind me, that one must be fixed to use names from
> > pci_ids.h
> > 
> For now I used numbers like other elements of the table.

Fair enough.

> If I
> would do the conversion I would use convenience marcros to not have
> names like PCI_CLASS_NETWORK_TOKEN_RING all over the table :)
> 
> --
> 			Gleb.

I'd prefer to keep it simple :)

-- 
MST