From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34411 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PGmM0-0003Qi-S9 for qemu-devel@nongnu.org; Fri, 12 Nov 2010 00:39:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PGmLz-0003Ck-U8 for qemu-devel@nongnu.org; Fri, 12 Nov 2010 00:39:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PGmLz-0003CV-N6 for qemu-devel@nongnu.org; Fri, 12 Nov 2010 00:39:15 -0500 Date: Fri, 12 Nov 2010 07:39:07 +0200 From: "Michael S. Tsirkin" Message-ID: <20101112053907.GC7631@redhat.com> References: <20101112024710.31423.99667.stgit@s20.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101112024710.31423.99667.stgit@s20.home> Subject: [Qemu-devel] Re: [PATCH 0/8] PCI capability and device assignment improvements List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: chrisw@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org On Thu, Nov 11, 2010 at 07:54:49PM -0700, Alex Williamson wrote: > This series attempts to clean up capability support between common > code and device assignment. In doing so, we can move existing MSI & > MSI-X capabilities to offsets matching real hardware, and further > enable more capabilities to be exposed. Very good cleanup overall. Some further suggestions posted. Thanks! > The last patch is only for RFC, I'd like some input on what we should > pass directly and where we should only provide read-only/emulated > access. Patches 1-7 are submitted for commit. Thanks, > > Alex > > --- > > Alex Williamson (8): > device-assignment: pass through and stub more PCI caps > pci: Pass ID for capability read/write handlers > device-assignment: Move PCI capabilities to match physical hardware > pci: Remove cap.length, cap.start, cap.supported > pci: Replace used bitmap with capability byte map > device-assignment: Use PCI capabilities support > pci: Remove pci_enable_capability_support() > pci: pci_default_cap_write_config ignores wmask > > > hw/device-assignment.c | 273 ++++++++++++++++++++++++++++++++++++------------ > hw/pci.c | 103 +++++++----------- > hw/pci.h | 25 ++-- > 3 files changed, 256 insertions(+), 145 deletions(-)