From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56057 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PGvzk-0004mW-Sf
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 10:56:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1PGvzj-000555-Aq
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 10:56:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:22160)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1PGvzj-00054h-33
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 10:56:55 -0500
Date: Fri, 12 Nov 2010 13:56:01 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20101112155601.GA312@amt.cnet>
References: <20101108190253.560821111@redhat.com>
	<4CD8E3E4.8010500@lab.ntt.co.jp> <20101109130843.GA24340@amt.cnet>
	<4CDBB1FA.1010402@lab.ntt.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CDBB1FA.1010402@lab.ntt.co.jp>
Subject: [Qemu-devel] Re: [patch 0/3] block migration fixes
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Cc: Kevin Wolf <kwolf@redhat.com>, ohmura.kei@lab.ntt.co.jp, qemu-devel@nongnu.org, Liran Schour <LIRANS@il.ibm.com>

On Thu, Nov 11, 2010 at 06:06:02PM +0900, Yoshiaki Tamura wrote:
> Marcelo Tosatti wrote:
> >On Tue, Nov 09, 2010 at 03:02:12PM +0900, Yoshiaki Tamura wrote:
> >>Marcelo Tosatti wrote:
> >>>Following patchset fixes block migration corruption issues.
> >>
> >>Hi Marcelo,
> >>
> >>Thanks for looking into this issue.  Although we tried your patches, we're still
> >>seeing the corruption.  If we execute block migration while copying a file
> >>locally, md5sum of the copied file doesn't match with the original.  Sometimes,
> >>the filesystem returns an I/O error.
> >>
> >>Could you let us know how you tested and debugged?  Did you use blkverify?
> >
> >Yoshiaki,
> >
> >I first reproduced corruption by copying a large file during "migrate
> >-i", with shared base on qcow2 filesystem, as in your original report.
> >
> >To debug the problem, file with different byte pattern at every 1MB
> >(size of dirty chunk) was created and copied directly to an IDE disk in
> >the guest. Raw format used for the disk image.
> >
> >With this patchset, i'm not able to reproduce the original issue
> >anymore.
> >
> >Can you please provide more details on how to reproduce?
> 
> Marcelo,
> 
> We double checked and the patchset does seem to fix the problem.
> The was a mistake in our test procedure.  Sorry for the confusion.
> 
> Thanks,
> 
> Yoshi

I was also experiencing corruption on automated test, but it turned out
to be fixed by kvm.git's ae8894c00b560bde4.

Thanks.