From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53596 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PHNC3-0003Zg-7C for qemu-devel@nongnu.org; Sat, 13 Nov 2010 15:59:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PHNC2-0003fT-64 for qemu-devel@nongnu.org; Sat, 13 Nov 2010 15:59:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PHNC1-0003f5-Ta for qemu-devel@nongnu.org; Sat, 13 Nov 2010 15:59:26 -0500 Date: Sat, 13 Nov 2010 22:59:15 +0200 From: "Michael S. Tsirkin" Message-ID: <20101113205915.GA23361@redhat.com> References: <20101112072411.GG29605@valinux.co.jp> <20101112091857.GH7631@redhat.com> <20101112095952.GA23183@valinux.co.jp> <20101112112630.GD11354@redhat.com> <20101112125030.GB27722@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101112125030.GB27722@valinux.co.jp> Subject: [Qemu-devel] Re: Cannot not unplug cold-plugged devices List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: Cam Macdonell , "qemu-devel@nongnu.org Developers" On Fri, Nov 12, 2010 at 09:50:30PM +0900, Isaku Yamahata wrote: > On Fri, Nov 12, 2010 at 01:26:30PM +0200, Michael S. Tsirkin wrote: > > No, I am just trying to understand why is hotplug event dangerous. > > We still get it if we do device add before starting the VM, right? > > I'm not sure if it's safe to call enable/disable_device() and > pm_update_sci() before starting VM. > So I'd like to avoid to call them instead of making sure it. > If someone else ensures its safety, I'm willing to eliminate the if clause. Well I don't think it's dangerous. I guess it makes sense for whatever is supplied on qemu command line to not cause a hotplug event. > -- > yamahata