From: "Michael S. Tsirkin" <mst@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: skandasa@cisco.com, adnan@khaleel.us, etmartin@cisco.com,
qemu-devel@nongnu.org, wexu2@cisco.com
Subject: [Qemu-devel] Re: [PATCH v7 2/6] pcie/aer: helper functions for pcie aer capability
Date: Mon, 15 Nov 2010 09:44:39 +0200 [thread overview]
Message-ID: <20101115074439.GB22248@redhat.com> (raw)
In-Reply-To: <20101115073512.GG27722@valinux.co.jp>
On Mon, Nov 15, 2010 at 04:35:12PM +0900, Isaku Yamahata wrote:
> On Tue, Nov 02, 2010 at 02:57:12PM +0200, Michael S. Tsirkin wrote:
> > > + pcie_add_capability(dev, PCI_EXT_CAP_ID_ERR, PCI_ERR_VER,
> > > + offset, PCI_ERR_SIZEOF);
> > > + exp = &dev->exp;
> > > + exp->aer_cap = offset;
> > > + if (dev->exp.aer_log.log_max == PCIE_AER_LOG_MAX_UNSET) {
> > > + dev->exp.aer_log.log_max = PCIE_AER_LOG_MAX_DEFAULT;
> > > + }
> > > + if (dev->exp.aer_log.log_max > PCIE_AER_LOG_MAX_MAX) {
> > > + dev->exp.aer_log.log_max = PCIE_AER_LOG_MAX_MAX;
> > > + }
> >
> > So someone should set log_max beforehand? And an illegal value is
> > rounded down? How is this API supposed to be used?
>
> It's qdev property. If log_max is too big, should it return error
> instead of silently rounding down?
I guess so. Ideally the legal range would be part of qdev, maybe we
can add this support.
> --
> yamahata
next prev parent reply other threads:[~2010-11-15 7:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 9:32 [Qemu-devel] [PATCH v7 0/6] pcie port switch emulators Isaku Yamahata
2010-11-02 9:32 ` [Qemu-devel] [PATCH v7 1/6] pcie_regs.h: more constants Isaku Yamahata
2010-11-02 9:32 ` [Qemu-devel] [PATCH v7 2/6] pcie/aer: helper functions for pcie aer capability Isaku Yamahata
2010-11-02 12:57 ` [Qemu-devel] " Michael S. Tsirkin
2010-11-03 1:24 ` Isaku Yamahata
2010-11-03 7:30 ` Michael S. Tsirkin
2010-11-15 7:35 ` Isaku Yamahata
2010-11-15 7:44 ` Michael S. Tsirkin [this message]
2010-11-02 13:54 ` Michael S. Tsirkin
2010-11-02 9:32 ` [Qemu-devel] [PATCH v7 3/6] pcie/aer: glue aer error injection into qemu monitor Isaku Yamahata
2010-11-02 12:10 ` [Qemu-devel] " Michael S. Tsirkin
2010-11-02 9:32 ` [Qemu-devel] [PATCH v7 4/6] ioh3420: support aer Isaku Yamahata
2010-11-02 9:32 ` [Qemu-devel] [PATCH v7 5/6] x3130/upstream: " Isaku Yamahata
2010-11-02 9:32 ` [Qemu-devel] [PATCH v7 6/6] x3130/downstream: " Isaku Yamahata
2010-11-02 14:05 ` [Qemu-devel] Re: [PATCH v7 0/6] pcie port switch emulators Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101115074439.GB22248@redhat.com \
--to=mst@redhat.com \
--cc=adnan@khaleel.us \
--cc=etmartin@cisco.com \
--cc=qemu-devel@nongnu.org \
--cc=skandasa@cisco.com \
--cc=wexu2@cisco.com \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).