From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46720 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PHusr-0002Yq-FJ
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 03:57:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yamahata@valinux.co.jp>) id 1PHusi-0003jw-EA
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 03:57:53 -0500
Received: from mail.valinux.co.jp ([210.128.90.3]:33796)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yamahata@valinux.co.jp>) id 1PHusi-0003jY-1x
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 03:57:44 -0500
Date: Mon, 15 Nov 2010 17:57:40 +0900
From: Isaku Yamahata <yamahata@valinux.co.jp>
Message-ID: <20101115085740.GH27722@valinux.co.jp>
References: <cover.1289805831.git.yamahata@valinux.co.jp>
	<3404152716bc65ee54b1c906b2435089a6200092.1289805831.git.yamahata@valinux.co.jp>
	<20101115080613.GE22248@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101115080613.GE22248@redhat.com>
Subject: [Qemu-devel] Re: [PATCH v8 07/11] pci: introduce a parser for pci
	device path
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: skandasa@cisco.com, adnan@khaleel.us, wexu2@cisco.com, gleb@redhat.com, qemu-devel@nongnu.org, etmartin@cisco.com

On Mon, Nov 15, 2010 at 10:06:13AM +0200, Michael S. Tsirkin wrote:
> On Mon, Nov 15, 2010 at 04:30:43PM +0900, Isaku Yamahata wrote:
> > introduce a function to parse pci device path of
> > the format, [Domain:]Slot.Function:Slot.Function....:Slot.Function.
> > 
> > Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> 
> Hmm.
> How about we use openfirmware path like what Gleb's patch does,
> with a fallback to bus:dev.fn for when it's unambiguous?

Okay, let me check my understanding of the format.

The openfirmware path in pci case looks like
/pci@<ioport>/<device name>@<slot>,<func>/.../<device name>@<slot>,<func>

"pci@<ioport>" corresponds to pci domain. So <mmio address> should be
also supported in addition to <ioport>.

Maybe we'd like "<device name>@" to be optional.
So the parser would accept something like
/{<ioport>, <mmio addr>}/<slot>,<func>/.../<slot>,<func>
-- 
yamahata