From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38417 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PHw8m-0001Km-IF
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 05:18:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1PHw8k-0002Pd-UR
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 05:18:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:11277)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1PHw8k-0002PI-NC
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 05:18:22 -0500
Date: Mon, 15 Nov 2010 12:18:17 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20101115101817.GJ7948@redhat.com>
References: <1289749181-12070-1-git-send-email-gleb@redhat.com>
	<1289749181-12070-14-git-send-email-gleb@redhat.com>
	<AANLkTimJ0xi6-Uu8k-T-C8OKLkHeiAPHP_1HZ28A9Bc7@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTimJ0xi6-Uu8k-T-C8OKLkHeiAPHP_1HZ28A9Bc7@mail.gmail.com>
Subject: [Qemu-devel] Re: [PATCHv4 13/15] Add bootindex for option roms.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: kvm@vger.kernel.org, mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, alex.williamson@redhat.com, kevin@koconnor.net

On Sun, Nov 14, 2010 at 09:33:06PM +0000, Blue Swirl wrote:
> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov <gleb@redhat.com> wrote:
> > Extend -option-rom command to have additional parameter ,bootindex=.
> 
> This patch is broken:
>   CC    arm-softmmu/palm.o
> /src/qemu/hw/palm.c: In function 'palmte_init':
> /src/qemu/hw/palm.c:237: error: incompatible type for argument 1 of
> 'get_image_size'
> /src/qemu/hw/palm.c:245: error: incompatible type for argument 1 of
> 'load_image_targphys'
> cc1: warnings being treated as errors
> /src/qemu/hw/palm.c:250: error: format '%s' expects type 'char *', but
> argument 4 has type 'QEMUOptionRom'
>   CC    arm-softmmu/nseries.o
> /src/qemu/hw/nseries.c: In function 'n8x0_init':
> /src/qemu/hw/nseries.c:1346: error: incompatible type for argument 1
> of 'load_image_targphys'
Fixed in new version.

--
			Gleb.