From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47786 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI0s8-00055H-8V for qemu-devel@nongnu.org; Mon, 15 Nov 2010 10:22:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PI0s7-0003rd-50 for qemu-devel@nongnu.org; Mon, 15 Nov 2010 10:21:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PI0s6-0003rW-UE for qemu-devel@nongnu.org; Mon, 15 Nov 2010 10:21:31 -0500 Date: Mon, 15 Nov 2010 17:21:18 +0200 From: "Michael S. Tsirkin" Message-ID: <20101115152118.GB30509@redhat.com> References: <20101104180406.GA2820@redhat.com> <5f91d600c749e66de107f60298c5ebd36645beff.1288892774.git.mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On Mon, Nov 15, 2010 at 03:52:54PM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > There's no reason for tap to run when VM is stopped. > > If we let it, it confuses the bridge on TX > > and corrupts DMA memory on RX. > > > > Signed-off-by: Michael S. Tsirkin > > once here, what handlers make sense to run while stopped? > /me can think of the normal console, non live migration, loadvm and not > much more. Perhaps it is easier to just move the other way around? > > Later, Juan. vnc? SDL? Yes, more devices need to be stopped than not, but I tread carefully to avoid breaking existing functionality. If you could solve it for all devices in one swoop, that'd be great. I'm not up to it. -- MST