From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58452 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PI2FY-0005yN-Sx
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 11:49:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mohan@in.ibm.com>) id 1PI2FU-0005vc-Qz
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 11:49:48 -0500
Received: from e23smtp06.au.ibm.com ([202.81.31.148]:53242)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mohan@in.ibm.com>) id 1PI2FU-0005u7-Ai
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 11:49:44 -0500
Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [202.81.31.247])
	by e23smtp06.au.ibm.com (8.14.4/8.13.1) with ESMTP id oAFGncQ9011019
	for <qemu-devel@nongnu.org>; Tue, 16 Nov 2010 03:49:38 +1100
Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])
	by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	oAFGnefN1507496
	for <qemu-devel@nongnu.org>; Tue, 16 Nov 2010 03:49:41 +1100
Received: from d23av01.au.ibm.com (loopback [127.0.0.1])
	by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	oAFGneJX012004
	for <qemu-devel@nongnu.org>; Tue, 16 Nov 2010 03:49:40 +1100
From: "M. Mohan Kumar" <mohan@in.ibm.com>
Date: Mon, 15 Nov 2010 22:19:36 +0530
References: <BC00F5384FCFC9499AF06F92E8B78A9E1AC3EFA17E@shsmsx502.ccr.corp.intel.com>
	<4CE0969D.5070703@jp.fujitsu.com> <4CE097C4.3070700@jp.fujitsu.com>
In-Reply-To: <4CE097C4.3070700@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201011152219.36635.mohan@in.ibm.com>
Subject: [Qemu-devel] Re: [PATCH v3] virtio-9p: fix build on
	!CONFIG_UTIMENSAT
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, Jes.Sorensen@redhat.com, "Hao, Xudong" <xudong.hao@intel.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Chris Wright <chrisw@sous-sol.org>, Avi Kivity <avi@redhat.com>

> This patch introduce a fallback mechanism for old systems that do not
> support utimensat().  This fix build failure with following warnings:
> 
> hw/virtio-9p-local.c: In function 'local_utimensat':
> hw/virtio-9p-local.c:479: warning: implicit declaration of function
> 'utimensat' hw/virtio-9p-local.c:479: warning: nested extern declaration
> of 'utimensat'
> 
> and:
> 
> hw/virtio-9p.c: In function 'v9fs_setattr_post_chmod':
> hw/virtio-9p.c:1410: error: 'UTIME_NOW' undeclared (first use in this
> function) hw/virtio-9p.c:1410: error: (Each undeclared identifier is
> reported only once hw/virtio-9p.c:1410: error: for each function it
> appears in.)
> hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this
> function) hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod':
> hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this
> function)
> 
> v3:
>   - Use better alternative handling for UTIME_NOW/OMIT
>   - Move qemu_utimensat() to cutils.c
> V2:
>   - Introduce qemu_utimensat()
> 
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>

Looks good to me.

Acked-by: M. Mohan Kumar <mohan@in.ibm.com>