From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53503 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI7nA-0002fp-5e for qemu-devel@nongnu.org; Mon, 15 Nov 2010 17:44:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PI7n8-0000ZE-L7 for qemu-devel@nongnu.org; Mon, 15 Nov 2010 17:44:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PI7n8-0000R1-D6 for qemu-devel@nongnu.org; Mon, 15 Nov 2010 17:44:50 -0500 Date: Tue, 16 Nov 2010 00:44:33 +0200 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device Message-ID: <20101115224433.GA5987@redhat.com> References: <20101104180406.GA2820@redhat.com> <5f91d600c749e66de107f60298c5ebd36645beff.1288892774.git.mst@redhat.com> <4CE149CB.1040301@codemonkey.ws> <20101115151817.GA30509@redhat.com> <4CE15B39.5070207@codemonkey.ws> <4CE1A0A3.4050406@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CE1A0A3.4050406@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Stefan Hajnoczi , qemu-devel@nongnu.org, Juan Quintela On Mon, Nov 15, 2010 at 03:05:39PM -0600, Anthony Liguori wrote: > On 11/15/2010 02:53 PM, Stefan Hajnoczi wrote: > > > >vhost has a solution for this: register a VMChangeStateHandler > >function that stops ioeventfd while vm_stop(0) is in effect. Then > >poll to see if there is work pending. > > > >I will add equivalent functionality to virtio-ioeventfd. > > I still think that stopping this at the net/block layer is going to > be a lot more robust in the long term. > All net/block traffic flows > through a single set of interfaces whereas getting the devices to > completely stop themselves requires touching every device and making > sure that noone adds back vmstop-unfriendly behavior down the road. > > Regards, > > Anthony Liguori So I'm not sure I understand what is proposed here. Care posting a patch? -- MST