From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43908 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PIHO1-0000tM-KC
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 03:59:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1PIHNy-0006CF-UX
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 03:59:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33290)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1PIHNy-0006C7-Ll
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 03:59:30 -0500
Date: Tue, 16 Nov 2010 10:59:25 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv5 01/15] Introduce fw_name field to
	DeviceInfo structure.
Message-ID: <20101116085925.GQ7948@redhat.com>
References: <1289831469-25540-1-git-send-email-gleb@redhat.com>
	<1289831469-25540-2-git-send-email-gleb@redhat.com>
	<20101116080935.GB23139@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101116080935.GB23139@valinux.co.jp>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: kvm@vger.kernel.org, mst@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, alex.williamson@redhat.com, kevin@koconnor.net

On Tue, Nov 16, 2010 at 05:09:35PM +0900, Isaku Yamahata wrote:
> On Mon, Nov 15, 2010 at 04:30:55PM +0200, Gleb Natapov wrote:
> > diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> > index b5589b9..38f9d9e 100644
> > --- a/hw/piix_pci.c
> > +++ b/hw/piix_pci.c
> > @@ -365,6 +365,7 @@ static PCIDeviceInfo i440fx_info[] = {
> >  static SysBusDeviceInfo i440fx_pcihost_info = {
> >      .init         = i440fx_pcihost_initfn,
> >      .qdev.name    = "i440FX-pcihost",
> > +    .qdev.fw_name = "pci",
> >      .qdev.size    = sizeof(I440FXState),
> >      .qdev.no_user = 1,
> >  };
> 
> There are other pci host bridges for not pc architecture
> which needs similar modification.
Yes, I know. This patch doesn't try to add fw_name everywhere it is
needed, just for x86 for now. Things can be added incrementally.

> Please grep by pci_register_bus().
> - apb_pci.c
> - bonito.c
> - grackle_pci.c
> - unin_pci.c
> - versatile_pci.c
I'll look into using BusInfo->name if fw_name is not available. Then all
pci buses will work.

> 
> BTW, what happens for non-qdevfied pci host bridge?
They should be converted someday.

--
			Gleb.