From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41602 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PILws-0004QK-NQ
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 08:51:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PILwn-0000po-I8
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 08:51:46 -0500
Received: from mx1.redhat.com ([209.132.183.28]:18189)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PILwn-0000pX-B7
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 08:51:45 -0500
Date: Tue, 16 Nov 2010 11:51:22 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 0/2] v8 Decouple block device removal
	from device removal
Message-ID: <20101116115122.298b758e@doriath>
In-Reply-To: <4CDD7BB1.5060504@redhat.com>
References: <1289581634-21177-1-git-send-email-ryanh@us.ibm.com>
	<4CDD7BB1.5060504@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Anthony Liguori <aliguori@linux.vnet.ibm.com>, Ryan Harper <ryanh@us.ibm.com>, Stefan Hajnoczi <stefan.hajnoczi@uk.ibm.com>

On Fri, 12 Nov 2010 18:38:57 +0100
Kevin Wolf <kwolf@redhat.com> wrote:

> Am 12.11.2010 18:07, schrieb Ryan Harper:
> > details, details, v8
> > 
> > This patch series decouples the detachment of a block device from the
> > removal of the backing pci-device.  Removal of a hotplugged pci device
> > requires the guest to respond before qemu tears down the block device.
> > In some cases, the guest may not respond leaving the guest with
> > continued access to the block device.  Mgmt layer doesn't have a
> > reliable method to force a disconnect.  
> > 
> > The new monitor command, drive_del, will revoke a guests access to the
> > block device independently of the removal of the pci device.
> > 
> > The first patch implements drive_del, the second patch implements the
> > qmp version of the monitor command.
> > 
> > Changes since v7:
> > - Fixed up doc strings (delete -> drive_del)
> > Changes since v6:
> > - Updated patch description
> > - Dropped bdrv_unplug and inlined in drive_del
> > - Explicitly invoke drive_uninit()
> > Changes since v5:
> > - Removed dangling pointers in guest and host state.  This ensures things like 
> >   info block no longer displays the deleted drive; though info pci will
> >   continue to display the pci device until the guest responds to the removal
> >   request.
> > - Renamed drive_unplug -> drive_del
> > Changes since v4:
> > - Droppped drive_get_by_id patch and use bdrv_find() instead
> > - Added additional details about drive_unplug to hmp/qmp interface
> > 
> > Changes since v3:
> > - Moved QMP command for drive_unplug() to separate patch
> > 
> > Changes since v2:
> > - Added QMP command for drive_unplug()
> > 
> > Changes since v1:
> > - CodingStyle fixes
> > - Added qemu_aio_flush() to bdrv_unplug()
> > 
> > Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
> 
> Thanks, applied both to the block branch.

I guess the conclusion was that we don't want the new command
in QMP?

  http://lists.gnu.org/archive/html/qemu-devel/2010-11/msg01084.html