From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44657 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PIOoN-0006sX-1c
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 11:55:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1PIOoK-0000xL-Qy
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 11:55:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:24613)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1PIOoK-0000wo-H7
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 11:55:12 -0500
Date: Tue, 16 Nov 2010 16:55:06 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Introduce -accel command option.
Message-ID: <20101116165506.GE1310@redhat.com>
References: <1289835951-25567-1-git-send-email-anthony.perard@citrix.com>
	<4CE165E0.5040705@codemonkey.ws>
	<alpine.DEB.1.10.1011161545090.7001@perard.cam.xci-test.com>
	<4CE2B435.4060003@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CE2B435.4060003@codemonkey.ws>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony PERARD <anthony.perard@citrix.com>, QEMU-devel <qemu-devel@nongnu.org>

On Tue, Nov 16, 2010 at 10:41:25AM -0600, Anthony Liguori wrote:
> On 11/16/2010 10:10 AM, Anthony PERARD wrote:
> >On Mon, 15 Nov 2010, Anthony Liguori wrote:
> >
> >   
> >>On 11/15/2010 09:45 AM, anthony.perard@citrix.com wrote:
> >>     
> >>>From: Anthony PERARD<anthony.perard@citrix.com>
> >>>
> >>>This option gives the ability to switch one "accelerator" like kvm, xen
> >>>or the default one tcg. We can specify more than one accelerator by
> >>>separate them by a comma. QEMU will try each one and use the first whose
> >>>works.
> >>>
> >>>So,
> >>>
> >>>-accel xen,kvm,tcg
> >>>
> >>>which would try Xen support first, then KVM and finaly tcg if none of
> >>>the other works.
> >>>
> >>>       
> >>Should use QemuOpts instead of parsing by hand.
> >>     
> >Ok for that.
> >
> >   
> >>I'd rather it be
> >>presented as a -machine option too with accel=xen:kvm:tcg to specify 
> >>order.
> >>     
> >This is not clear to me, did you mean that you prefer to have both
> >"-accel accels" and "-machine accel=accels" options?
> >   
> 
> Just -machine accel=accels.
> 
> Part of my rational is that accelerator is a machine property.  If you 
> do -M xenpv it ought to imply -machine accel=xen.

Surely, only if it is running on a Xen Dom0. If you use -M xenpv on a KVM
host, then -M xenpv should imply -machine accel=kvm (ie it would be using
xenner)

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|