From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41270 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PIgJr-0003od-6O for qemu-devel@nongnu.org; Wed, 17 Nov 2010 06:36:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PIgJp-0003CH-LO for qemu-devel@nongnu.org; Wed, 17 Nov 2010 06:36:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PIgJp-0003CD-Ee for qemu-devel@nongnu.org; Wed, 17 Nov 2010 06:36:53 -0500 Date: Wed, 17 Nov 2010 11:36:48 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability Message-ID: <20101117113648.GB29020@redhat.com> References: <1289244788-19961-1-git-send-email-berrange@redhat.com> <1289244788-19961-2-git-send-email-berrange@redhat.com> <4CE2A74C.6050302@codemonkey.ws> <4CE2C92E.3030006@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org On Tue, Nov 16, 2010 at 06:54:57PM +0000, Peter Maydell wrote: > On 16 November 2010 18:10, Anthony Liguori wrote: > > On 11/16/2010 11:43 AM, Peter Maydell wrote: > >> Unfortunately these commits: > >> 2834c3e Add support for generating a systemtap tapset static probes > >> 4addb11 Add a DTrace tracing backend targetted for SystemTAP compatability > > > > What's your configure output? > > I've attached it; the trace related bits are: > Trace backend nop > Trace output file trace- > > > I don't have the right environment to build with systemtap support, but > > --trace-backend=nop should work regardless. > > I'm using the nop backend, yes. > > I think the problem is that commit 2834c3e adds a target 'trace:' to the > Makefile.target which looks like it's intended to be a phony target. However > it isn't marked as such, so make actually tries to create a binary 'trace' > by falling back to its default rules (since there's a "trace.c" in the root > directory): This Makefile problem was fixed in the v6 patches I posted on Nov 12th http://lists.gnu.org/archive/html/qemu-devel/2010-11/msg01033.html Unfortunately the v5 patches were applied by mistake. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|