From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37886 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PIj9k-0005f0-Kh for qemu-devel@nongnu.org; Wed, 17 Nov 2010 09:38:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PIj9g-0004H5-AM for qemu-devel@nongnu.org; Wed, 17 Nov 2010 09:38:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PIj9g-0004Gp-3A for qemu-devel@nongnu.org; Wed, 17 Nov 2010 09:38:36 -0500 Date: Wed, 17 Nov 2010 16:38:20 +0200 From: "Michael S. Tsirkin" Message-ID: <20101117143820.GA15318@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [Qemu-devel] Re: [PATCH v9 0/8] pcie port switch emulators List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: skandasa@cisco.com, adnan@khaleel.us, etmartin@cisco.com, qemu-devel@nongnu.org, wexu2@cisco.com On Tue, Nov 16, 2010 at 05:26:04PM +0900, Isaku Yamahata wrote: > Now v9 of pcie aer patch series. > I dropped qmp patch to inject aer error because it will depends > on Gleb's openfirmware path patches. > Once his patches are merged, the glue patch will be respined. > > Patch description: > The patch series adds pcie/aer functionality to the pcie port emulators > and adds new qemu command to inject aer into the guest. > > Change v8 -> v9: > - dropped qmp glue aer error injection. > - folded pci command register initialization patches > - make pcie_aer_init() return error > > Changes v7 -> v8: > - Added command to the forward declaration. > - revise pci command/status register initialization > - various changes to follow the review > - use domain:slot.func:slot.func..:slot.func to specify pci function > instead of domain:bus:slot.func > - allow symbolic name for aer error name in addition to 32 bit value > > Changes v6 -> v7: > - the glue patch for pushing attention button is dropped for now. > This will be addressed later. > - various clean up of aer helper functions. > > changes v5 -> v6: > - dropped already merged patches. > - add comment on hpev_intx > - updated the bridge fix patch > - update the aer patch. > - reordered the patch series to remove the aer dependency. > > change v4 -> v5: > - introduced pci_xxx_test_and_clear/set_mask > - eliminated xxx_notify(msi_trigger, int_level) > - eliminated FLR bits. > FLR will be addressed at the next phase. > > changes v3 -> v4: > - introduced new pci config helper functions.(clear set bit) > - various clean up and some bug fixes. > - dropped pci_shift_xxx(). > - dropped function pointerin pcie_aer.h > - dropped pci_exp_cap(), pcie_aer_cap(). > - file rename (pcie_{root, upstream, downsatrem} => ioh33420, x3130). > > changes v2 -> v3: > - msi: improved commant and simplified shift/ffs dance > - pci w1c config register framework > - split pcie.[ch] into pcie_regs.h, pcie.[ch] and pcie_aer.[ch] > - pcie, aer: many changes by following reviews. > > changes v1 -> v2: > - update msi > - dropped already pushed out patches. > - added msix patches. > > Isaku Yamahata (8): > pci: revise pci command register initialization > pci: fix accesses to pci status register I dropped these for now. Maybe for AER we'll need a small patch to make SERR enable writeable + a compatibility flag set in machine description for 0.13 and back? If yes let's do just this, leave IO/MEMORY alone. > pci: clean up of pci status register Applied a minimal subset for AER. > pcie_regs.h: more constants Applied after fixing up the comment. > pcie/aer: helper functions for pcie aer capability Applied, added cleanup patches on top to remove recursion > ioh3420: support aer > x3130/upstream: support aer > x3130/downstream: support aer. Applied. > > Makefile.objs | 2 +- > hw/ioh3420.c | 80 ++++- > hw/pci.c | 120 +++++++- > hw/pcie.h | 14 + > hw/pcie_aer.c | 827 +++++++++++++++++++++++++++++++++++++++++++++++ > hw/pcie_aer.h | 106 ++++++ > hw/pcie_regs.h | 2 + > hw/xio3130_downstream.c | 43 ++- > hw/xio3130_upstream.c | 33 ++- > qemu-common.h | 3 + > 10 files changed, 1189 insertions(+), 41 deletions(-) > create mode 100644 hw/pcie_aer.c > create mode 100644 hw/pcie_aer.h