From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49210 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJNtE-0004hY-8Y for qemu-devel@nongnu.org; Fri, 19 Nov 2010 05:08:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJNt8-0006Tm-DA for qemu-devel@nongnu.org; Fri, 19 Nov 2010 05:08:19 -0500 Received: from va3ehsobe006.messaging.microsoft.com ([216.32.180.16]:1207 helo=VA3EHSOBE008.bigfish.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJNt8-0006Td-Ad for qemu-devel@nongnu.org; Fri, 19 Nov 2010 05:08:14 -0500 Date: Fri, 19 Nov 2010 11:08:04 +0100 From: "Roedel, Joerg" Message-ID: <20101119100804.GA2146@amd.com> References: <1290050875-23848-1-git-send-email-agraf@suse.de> <1290050875-23848-9-git-send-email-agraf@suse.de> <4CE4DD74.3070801@redhat.com> <4CE56AED.8070906@suse.de> <4CE63F8B.8020802@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4CE63F8B.8020802@redhat.com> Subject: [Qemu-devel] Re: [PATCH 08/10] ahci: add ahci emulation List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Stefan Hajnoczi , Herbszt , Alexander Graf , QEMU-devel Developers , "tj@kernel.org" , Sebastian@gnu.org, Roland Elek On Fri, Nov 19, 2010 at 04:12:43AM -0500, Gerd Hoffmann wrote: > >>> +static void ahci_check_irq(AHCIState *s) > >> > >> MSI support would be nice to have. > > > > Alrighty, I added MSI support. But I only have a single vector in use > > atm as nvec> 0 doesn't get written to the PCI config space so the code > > trips on that later on. > > For multiple vectors MSI-X is the best choice as it fixes a few design > issues MSI has when it comes to multiple vectors. I think linux never > ever uses MSI with multiple vectors anyway. Linux doesn't even support MSI with multiple vectors today. Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632