From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org,
kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 10/16] scsi: Use 'SCSIRequest' directly
Date: Fri, 19 Nov 2010 19:27:23 +0100 [thread overview]
Message-ID: <20101119182723.GA32461@lst.de> (raw)
In-Reply-To: <20101118144728.9581CF90AB@ochil.suse.de>
On Thu, Nov 18, 2010 at 03:47:28PM +0100, Hannes Reinecke wrote:
>
> Rather than to access a SCSIRequest via an abstract 'tag' we can
> as well use it directly and save us the lookup.
The get_put/buf methods are a bit misnamed. get/put generally implies
refcounting while they are simple alloc/free routines. I'd suggest
renaming them to alloc_buf/free_buf.
Otherwise the patch looks very good to me.
prev parent reply other threads:[~2010-11-19 18:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 14:47 [Qemu-devel] [PATCH 10/16] scsi: Use 'SCSIRequest' directly Hannes Reinecke
2010-11-18 16:16 ` [Qemu-devel] " Gerd Hoffmann
2010-11-18 16:33 ` Hannes Reinecke
2010-11-19 8:02 ` Gerd Hoffmann
2010-11-19 18:27 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101119182723.GA32461@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kraxel@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).