From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57592 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PJVgN-0006BW-Ec
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 13:27:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1PJVgM-0005Ca-K9
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 13:27:35 -0500
Received: from verein.lst.de ([213.95.11.210]:41674)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1PJVgM-0005C1-5u
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 13:27:34 -0500
Date: Fri, 19 Nov 2010 19:27:23 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 10/16] scsi: Use 'SCSIRequest' directly
Message-ID: <20101119182723.GA32461@lst.de>
References: <20101118144728.9581CF90AB@ochil.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101118144728.9581CF90AB@ochil.suse.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hannes Reinecke <hare@suse.de>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org, kraxel@redhat.com

On Thu, Nov 18, 2010 at 03:47:28PM +0100, Hannes Reinecke wrote:
> 
> Rather than to access a SCSIRequest via an abstract 'tag' we can
> as well use it directly and save us the lookup.

The get_put/buf methods are a bit misnamed.  get/put generally implies
refcounting while they are simple alloc/free routines.  I'd suggest
renaming them to alloc_buf/free_buf.

Otherwise the patch looks very good to me.