From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org,
kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 03/16] scsi: Return SAM status codes
Date: Fri, 19 Nov 2010 19:33:32 +0100 [thread overview]
Message-ID: <20101119183332.GD32461@lst.de> (raw)
In-Reply-To: <20101118144632.390C5F90AB@ochil.suse.de>
On Thu, Nov 18, 2010 at 03:46:32PM +0100, Hannes Reinecke wrote:
>
> The SCSI emulation is supposed to return status codes as defined
> by SAM, not the linux ones which are shifted by one.
When just looking at the patch the description is rather confusing as
all places touched were already returning the correct value by doing
the opencoded shift. Only a little grepping reveals that there are
lots of other incorrect uses, too. You might consider mentioning
this in the patch description.
prev parent reply other threads:[~2010-11-19 18:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 14:46 [Qemu-devel] [PATCH 03/16] scsi: Return SAM status codes Hannes Reinecke
2010-11-19 18:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101119183332.GD32461@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kraxel@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).