From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55416 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PJVoH-0001kV-85
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 13:35:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1PJVoF-0006UC-V0
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 13:35:45 -0500
Received: from verein.lst.de ([213.95.11.210]:48597)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1PJVoF-0006U5-LF
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 13:35:43 -0500
Date: Fri, 19 Nov 2010 19:35:40 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 06/16] scsi-disk: Remove duplicate cdb parsing
Message-ID: <20101119183540.GG32461@lst.de>
References: <20101118144709.D26D0F90AB@ochil.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101118144709.D26D0F90AB@ochil.suse.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hannes Reinecke <hare@suse.de>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org, kraxel@redhat.com

On Thu, Nov 18, 2010 at 03:47:09PM +0100, Hannes Reinecke wrote:
> 
> We parse the CDB twice, which is completely unnecessary.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>

Looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>