qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: skandasa@cisco.com, etmartin@cisco.com, wexu2@cisco.com,
	qemu-devel@nongnu.org, kraxel@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] Re: [PATCH v2 0/6] qdev reset refactoring and pci bus reset
Date: Mon, 22 Nov 2010 12:54:44 +0200	[thread overview]
Message-ID: <20101122105444.GA25877@redhat.com> (raw)
In-Reply-To: <20101122104337.GB24265@valinux.co.jp>

On Mon, Nov 22, 2010 at 07:43:37PM +0900, Isaku Yamahata wrote:
> On Mon, Nov 22, 2010 at 09:54:02AM +0200, Michael S. Tsirkin wrote:
> > On Fri, Nov 19, 2010 at 06:55:57PM +0900, Isaku Yamahata wrote:
> > > Here is v2. I updated the comments, and dropped the pci qdev reset patch.
> > > 
> > > Patch description:
> > > The goal of this patch series is to implement secondary bus reset
> > > emulation in pci-to-pci bridge.
> > > At first, this patch series refactors qdev reset,
> > > and then cleans up pci bus reset. Lastly implements pci bridge control
> > > secondary bus reset bit.
> > > 
> > > This patch series is for pci bus reset, which is ported
> > > from the following repo.
> > > git://repo.or.cz/qemu/aliguori.git qdev-refactor
> > 
> > I've put the series on my pci branch, tweaking patches 5 and 6 in the
> > process.  Out of time to compile-tested only for now.
> 
> Thank you. The tweaking looks good.
> Do you still want me to send another patch to add a comment on RST#?

Probably not. I'm not sure I understand what the conventional
PCI spec says: should devices be reset on 0->1
transition, or kept in reset state until this bit is cleared?
And it seems quite clear that in the express
case the reset is only for 0->1 transition.
I've asked for clarification from pcisig.

> -- 
> yamahata

  reply	other threads:[~2010-11-22 10:55 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-19  9:55 [Qemu-devel] [PATCH v2 0/6] qdev reset refactoring and pci bus reset Isaku Yamahata
2010-11-19  9:55 ` [Qemu-devel] [PATCH v2 1/6] qbus: add functions to walk both devices and busses Isaku Yamahata
2010-11-19  9:55 ` [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree Isaku Yamahata
2010-12-16 19:31   ` Stefan Weil
2010-12-16 23:48     ` Michael S. Tsirkin
2010-12-17  0:24       ` Anthony Liguori
2010-12-17 14:45         ` Peter Maydell
2010-12-17 14:56           ` Anthony Liguori
2010-12-20 12:58             ` Markus Armbruster
2010-12-20 19:40               ` Stefan Weil
2010-12-20 21:01                 ` Markus Armbruster
2010-12-17  4:29     ` Isaku Yamahata
2010-12-17  4:47       ` Isaku Yamahata
2010-12-18 18:11         ` Stefan Weil
2010-12-19 13:25           ` Michael S. Tsirkin
2010-11-19  9:56 ` [Qemu-devel] [PATCH v2 3/6] qdev: introduce reset call back for qbus level Isaku Yamahata
2010-11-19  9:56 ` [Qemu-devel] [PATCH v2 4/6] qdev: introduce a helper function which triggers reset from a given device Isaku Yamahata
2010-11-19  9:56 ` [Qemu-devel] [PATCH v2 5/6] pci: make use of qdev reset frame work to pci bus reset Isaku Yamahata
2010-11-19  9:56 ` [Qemu-devel] [PATCH v2 6/6] pci bridge: implement secondary " Isaku Yamahata
2010-11-19 12:00   ` [Qemu-devel] " Michael S. Tsirkin
2010-11-22  7:54 ` [Qemu-devel] Re: [PATCH v2 0/6] qdev reset refactoring and pci " Michael S. Tsirkin
2010-11-22 10:43   ` Isaku Yamahata
2010-11-22 10:54     ` Michael S. Tsirkin [this message]
2010-11-22 22:53     ` Michael S. Tsirkin
2010-11-23 18:10       ` Michael S. Tsirkin
2010-11-24  2:37         ` Isaku Yamahata
2010-11-24  5:27           ` Michael S. Tsirkin
2010-11-24  7:15             ` Isaku Yamahata
2010-11-24 10:59               ` Michael S. Tsirkin
2010-11-24 11:09                 ` Isaku Yamahata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101122105444.GA25877@redhat.com \
    --to=mst@redhat.com \
    --cc=etmartin@cisco.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=skandasa@cisco.com \
    --cc=wexu2@cisco.com \
    --cc=yamahata@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).