From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46796 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PKURv-0000RG-V5
	for qemu-devel@nongnu.org; Mon, 22 Nov 2010 06:20:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1PKURu-00006s-Ul
	for qemu-devel@nongnu.org; Mon, 22 Nov 2010 06:20:43 -0500
Received: from verein.lst.de ([213.95.11.210]:39139)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1PKURu-00004s-MR
	for qemu-devel@nongnu.org; Mon, 22 Nov 2010 06:20:42 -0500
Date: Mon, 22 Nov 2010 12:20:32 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 11/16] scsi-disk: add data direction checking
Message-ID: <20101122112032.GA1579@lst.de>
References: <20101118144732.99F4CF90AB@ochil.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101118144732.99F4CF90AB@ochil.suse.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hannes Reinecke <hare@suse.de>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org, kraxel@redhat.com

On Thu, Nov 18, 2010 at 03:47:32PM +0100, Hannes Reinecke wrote:
> 
> scsi_req_parse() already provides for a data direction setting,
> so we should be using it to check for correct direction.

Instead of just a debug printf that almost no one compiles in shouldn't
we reject the incorrect commands?