From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48350 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PKsE6-0001js-7N
	for qemu-devel@nongnu.org; Tue, 23 Nov 2010 07:44:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PKsE4-0005k3-AX
	for qemu-devel@nongnu.org; Tue, 23 Nov 2010 07:44:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35151)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PKsE4-0005jP-2b
	for qemu-devel@nongnu.org; Tue, 23 Nov 2010 07:44:00 -0500
Date: Tue, 23 Nov 2010 10:43:48 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20101123104348.5d44e89e@doriath>
In-Reply-To: <4CEB5406.3060300@cn.fujitsu.com>
References: <4CEB5406.3060300@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] correct migrate_set_speed's args_type
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Tue, 23 Nov 2010 13:41:26 +0800
Wen Congyang <wency@cn.fujitsu.com> wrote:

> The args_type of migrate_set_speed in qmp-commands.hx is wrong.
> When we set migrate speed by json, qemu will be core dumped.
> 
> Signed-off-by: Wen Congyang

Nice catch.

Was caused by 07de3e60b05 and hence affects master only. Could you please
mention that in the commit log? Also, your email address is missing
in the signed-off-by line.

> 
> ---
>  qmp-commands.hx |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 793cf1c..16bdb08 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -495,7 +495,7 @@ EQMP
>  
>      {
>          .name       = "migrate_set_speed",
> -        .args_type  = "value:f",
> +        .args_type  = "value:o",
>          .params     = "value",
>          .help       = "set maximum speed (in bytes) for migrations",
>          .user_print = monitor_user_noop,